All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Subject: Re: [Qemu-devel] [PATCH 1/1] Make the e1000 the default network adapter for the pc target.
Date: Wed, 26 Aug 2009 11:32:45 +0300	[thread overview]
Message-ID: <4A94F32D.9050509@redhat.com> (raw)
In-Reply-To: <4A942B1D.1040801@us.ibm.com>

On 08/25/2009 09:19 PM, Anthony Liguori wrote:
> Avi Kivity wrote:
>> if (0) is usually optimized away by the compiler.
>>
>> The default only matters to unmanaged systems.  I think we should aim 
>> first for working, and later for performance.
>
> An "unmanaged system" includes a standard distribution where the user 
> is using virt-manager. 

 From the name, I would have thought that virt-manager is a managed system.

> That's what led me down this road in the first place.
>

I don't follow the logic at all.  If qemu is started with model= (which 
I'd guess a managed system will do), it doesn't matter what the default 
is.  If qemu is not started with model= (which I'd expect from command 
line), then we should make every effort to bring up a working guest.

Have we run out of unintended regressions that we've started to add 
intended ones?

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2009-08-26  8:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-14 16:23 [Qemu-devel] [PATCH 1/1] Make the e1000 the default network adapter for the pc target Anthony Liguori
2009-08-15 21:58 ` [Qemu-devel] Re: [PATCH 1/1] Make the e1000 the default network adapterfor " Sebastian Herbszt
2009-08-17 10:34 ` [Qemu-devel] [PATCH 1/1] Make the e1000 the default network adapter for " Mark McLoughlin
2009-08-24 15:12   ` Anthony Liguori
2009-08-24 15:36     ` Gerd Hoffmann
2009-08-24 16:14       ` Anthony Liguori
2009-08-25 10:45 ` Avi Kivity
2009-08-25 12:39   ` Anthony Liguori
2009-08-25 15:55     ` Avi Kivity
2009-08-25 13:23   ` Lennart Sorensen
2009-08-25 13:34     ` Anthony Liguori
2009-08-25 14:23       ` Lennart Sorensen
2009-08-25 16:00       ` Avi Kivity
2009-08-25 15:58     ` Avi Kivity
2009-08-25 16:30       ` Lennart Sorensen
2009-08-25 16:39         ` Anthony Liguori
2009-08-25 16:56           ` Avi Kivity
2009-08-25 17:11             ` Lennart Sorensen
2009-08-25 17:13               ` Avi Kivity
2009-08-25 18:19                 ` Anthony Liguori
2009-08-26  8:32                   ` Avi Kivity [this message]
2009-08-25 17:28               ` Reimar Döffinger
2009-08-26  5:47           ` Amit Shah
2009-08-25 20:20       ` [Qemu-devel] " Bjørn Mork
2009-08-26  9:57         ` Avi Kivity
2009-08-25 13:51   ` [Qemu-devel] " Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A94F32D.9050509@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=lsorense@csclub.uwaterloo.ca \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.