All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] OMAP3: make TWL4030 optional for MMC driver
Date: Thu, 27 Aug 2009 16:07:57 +0200	[thread overview]
Message-ID: <4A96933D.7050706@googlemail.com> (raw)
In-Reply-To: <4A968D39.1030900@windriver.com>

Tom wrote:
> Maybe it would be better if the power_init function was removed from the 
> common file and moved to the individual board files.  What do you think ?
> Tom

Yes, sounds like a good idea.

Best regards

Dirk

> Matthias Ludwig wrote:
>> Upcoming boards may power MMC card themself without using
>> TWL4030, so make it optional by using define CONFIG_TWL4030_MMC.
>>
>> Enable this for all existing OMAP3 boards.
>>
>> Signed-off-by: Matthias Ludwig <mludwig@ultratronik.de>
>> ---
>>
>> Current OMAP3 MMC driver does require TWL4030 support to
>> be enabled as all OMAP3 boards are using this chip. I'd like
>> to push patches for a new board which does not has a TWL4030
>> and is caring about MMC power by itself.
>>
>> So, my suggestion is to make the TWL4030 dependency optional.
>> Are there better ways to to this can using a new define
>> CONFIG_TWL4030_MMC?
>>
>>  drivers/mmc/omap3_mmc.c         |    4 ++++
>>  include/configs/omap3_beagle.h  |    1 +
>>  include/configs/omap3_evm.h     |    1 +
>>  include/configs/omap3_overo.h   |    1 +
>>  include/configs/omap3_pandora.h |    1 +
>>  include/configs/omap3_zoom1.h   |    1 +
>>  include/configs/omap3_zoom2.h   |    1 +
>>  7 files changed, 10 insertions(+), 0 deletions(-)
....

  reply	other threads:[~2009-08-27 14:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-27 13:24 [U-Boot] [RFC] OMAP3: make TWL4030 optional for MMC driver Matthias Ludwig
2009-08-27 13:42 ` Tom
2009-08-27 14:07   ` Dirk Behme [this message]
2009-08-27 14:31     ` Matthias Ludwig
2009-08-27 14:45       ` Tom
2009-08-27 14:51         ` Matthias Ludwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A96933D.7050706@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.