hvr-1800 disabling audio on pvr-500?

hvr-1800 disabling audio on pvr-500?

[Jarod Wilson]

Haven't verified this myself, but there's a bugzilla ticket filed w/ 
Red Hat, claiming that audio on a pvr-500 is disabled when its in the  
same system as an hvr-1800.

https://bugzilla.redhat.com/show_bug.cgi?id=480728

Nonsense? Already fixed? Report says it worked fine in 2.6.25, broke  
in 2.6.27, not sure if later kernels have been tried. If its already  
fixed, and someone happens to know the commit that fixed it, I'd  
appreciate a pointer...

-- 
Jarod Wilson
jarod@wilsonet.com

Re: hvr-1800 disabling audio on pvr-500?

[Hans Verkuil]

On Monday 31 August 2009 19:45:08 Jarod Wilson wrote:
> Haven't verified this myself, but there's a bugzilla ticket filed w/ 
> Red Hat, claiming that audio on a pvr-500 is disabled when its in the  
> same system as an hvr-1800.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=480728
> 
> Nonsense? Already fixed? Report says it worked fine in 2.6.25, broke  
> in 2.6.27, not sure if later kernels have been tried. If its already  
> fixed, and someone happens to know the commit that fixed it, I'd  
> appreciate a pointer...
> 

Urgh. cx25840_loadfw() in cx25840_firmware.c contains this code:

        if (state->is_cx23885)
                firmware = FWFILE_CX23885;
        else if (state->is_cx231xx)
                firmware = FWFILE_CX231XX;

Unfortunately firmware is a global string module option, initially setup to
contain the 'normal' cx25840 firmware name.

So loading a cx23885 or a cx231xx will overwrite that string and if ivtv is
loaded afterwards it tries to load the wrong firmware.

Sigh...

I'll see if I have time to fix this today or tomorrow.

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom

Re: hvr-1800 disabling audio on pvr-500?

[Steven Toth]

> Sigh...
>
> I'll see if I have time to fix this today or tomorrow.

This might help:

http://www.kernellabs.com/hg/~stoth/cx25840-fw/rev/38c5fb14c770

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com

Re: hvr-1800 disabling audio on pvr-500?

[Jarod Wilson]

On Aug 31, 2009, at 3:06 PM, Steven Toth wrote:

>> Sigh...
>>
>> I'll see if I have time to fix this today or tomorrow.
>
> This might help:
>
> http://www.kernellabs.com/hg/~stoth/cx25840-fw/rev/38c5fb14c770

Haven't actually tested it, but at a glance through the code, yeah,  
that looks like a winner to me. I'll toss that in a kernel build for  
the original poster to test to confirm 100%, but for now:

Acked-by: Jarod Wilson <jarod@redhat.com>

-- 
Jarod Wilson
jarod@wilsonet.com