All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Torsten Kaiser <just.for.lkml@googlemail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	Linux-kernel <linux-kernel@vger.kernel.org>,
	xfs@oss.sgi.com
Subject: Re: xfs compat_ioctl?
Date: Tue, 01 Sep 2009 12:55:23 -0500	[thread overview]
Message-ID: <4A9D600B.4020405@sandeen.net> (raw)
In-Reply-To: <64bb37e0909011000l78a0aef0wf4c53252c14af75e@mail.gmail.com>

Torsten Kaiser wrote:
> On Mon, Aug 31, 2009 at 8:27 PM, Christoph Hellwig<hch@infradead.org> wrote:
>> I think you are right, the constant used is incorrect.  Does the small
>> patch below fix it for you?
> 
> Yes, after adding this patch, xfs_fsr works.

Crud, sorry about that.  I swear I ran 32-bit xfstests under a 64-bit
kernel, but I think we were lacking in fsr coverage....

-Eric

>> Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
>> ===================================================================
>> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c       2009-08-31 15:25:06.093044591 -0300
>> +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c    2009-08-31 15:25:10.856544216 -0300
>> @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
>>        case XFS_IOC_GETVERSION_32:
>>                cmd = _NATIVE_IOC(cmd, long);
>>                return xfs_file_ioctl(filp, cmd, p);
>> -       case XFS_IOC_SWAPEXT: {
>> +       case XFS_IOC_SWAPEXT_32: {
>>                struct xfs_swapext        sxp;
>>                struct compat_xfs_swapext __user *sxu = arg;
>>
>>
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@sandeen.net>
To: Torsten Kaiser <just.for.lkml@googlemail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	Linux-kernel <linux-kernel@vger.kernel.org>,
	xfs@oss.sgi.com
Subject: Re: xfs compat_ioctl?
Date: Tue, 01 Sep 2009 12:55:23 -0500	[thread overview]
Message-ID: <4A9D600B.4020405@sandeen.net> (raw)
In-Reply-To: <64bb37e0909011000l78a0aef0wf4c53252c14af75e@mail.gmail.com>

Torsten Kaiser wrote:
> On Mon, Aug 31, 2009 at 8:27 PM, Christoph Hellwig<hch@infradead.org> wrote:
>> I think you are right, the constant used is incorrect.  Does the small
>> patch below fix it for you?
> 
> Yes, after adding this patch, xfs_fsr works.

Crud, sorry about that.  I swear I ran 32-bit xfstests under a 64-bit
kernel, but I think we were lacking in fsr coverage....

-Eric

>> Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
>> ===================================================================
>> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c       2009-08-31 15:25:06.093044591 -0300
>> +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c    2009-08-31 15:25:10.856544216 -0300
>> @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
>>        case XFS_IOC_GETVERSION_32:
>>                cmd = _NATIVE_IOC(cmd, long);
>>                return xfs_file_ioctl(filp, cmd, p);
>> -       case XFS_IOC_SWAPEXT: {
>> +       case XFS_IOC_SWAPEXT_32: {
>>                struct xfs_swapext        sxp;
>>                struct compat_xfs_swapext __user *sxu = arg;
>>
>>
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 


  reply	other threads:[~2009-09-01 17:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-31  7:02 xfs compat_ioctl? Michael Tokarev
2009-08-31 12:30 ` Christoph Hellwig
2009-08-31 12:30   ` Christoph Hellwig
2009-08-31 12:57   ` Mark Lord
2009-08-31 12:57     ` Mark Lord
2009-08-31 12:59     ` Michael Tokarev
2009-08-31 12:59       ` Michael Tokarev
2009-08-31 18:14   ` Torsten Kaiser
2009-08-31 18:14     ` Torsten Kaiser
2009-08-31 18:27     ` Christoph Hellwig
2009-08-31 18:27       ` Christoph Hellwig
2009-08-31 18:42       ` Torsten Kaiser
2009-08-31 18:42         ` Torsten Kaiser
2009-09-01 17:00       ` Torsten Kaiser
2009-09-01 17:00         ` Torsten Kaiser
2009-09-01 17:55         ` Eric Sandeen [this message]
2009-09-01 17:55           ` Eric Sandeen
2009-08-31 18:37   ` Tim Walberg
2009-08-31 18:37     ` Tim Walberg
2009-08-31 18:48     ` Christoph Hellwig
2009-08-31 18:48       ` Christoph Hellwig
2009-08-31 18:48       ` Christoph Hellwig
2009-08-31 18:49       ` Christoph Hellwig
2009-08-31 18:49         ` Christoph Hellwig
2009-08-31 18:49         ` Christoph Hellwig
2009-08-31 19:02         ` Tim Walberg
2009-08-31 19:02           ` Tim Walberg
2009-09-02 11:51           ` Tim Walberg
2009-09-02 11:51             ` Tim Walberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9D600B.4020405@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=just.for.lkml@googlemail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.