* [PATCH-v2] Make git status print a helpful death message if the disk is full
@ 2009-09-01 20:27 David Reiss
0 siblings, 0 replies; only message in thread
From: David Reiss @ 2009-09-01 20:27 UTC (permalink / raw)
To: git
The old behavior just said that it failed. Now it includes the error
information, which makes it much easier to debug.
There is a risk that some failure paths could result in misleading error
messages that actually make debugging more difficult.
Signed-off-by: David Reiss <dreiss@facebook.com>
---
Sorry I missed that.
builtin-commit.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index 4bcce06..7feb598 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -256,7 +256,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix)
refresh_cache(REFRESH_QUIET);
if (write_cache(fd, active_cache, active_nr) ||
close_lock_file(&index_lock))
- die("unable to write new_index file");
+ die_errno("unable to write new_index file");
commit_style = COMMIT_NORMAL;
return index_lock.filename;
}
@@ -275,7 +275,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix)
refresh_cache(REFRESH_QUIET);
if (write_cache(fd, active_cache, active_nr) ||
commit_locked_index(&index_lock))
- die("unable to write new_index file");
+ die_errno("unable to write new_index file");
commit_style = COMMIT_AS_IS;
return get_index_file();
}
@@ -318,7 +318,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix)
refresh_cache(REFRESH_QUIET);
if (write_cache(fd, active_cache, active_nr) ||
close_lock_file(&index_lock))
- die("unable to write new_index file");
+ die_errno("unable to write new_index file");
fd = hold_lock_file_for_update(&false_lock,
git_path("next-index-%"PRIuMAX,
--
1.6.0.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-09-01 20:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-01 20:27 [PATCH-v2] Make git status print a helpful death message if the disk is full David Reiss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.