Re: EXT4: kernel BUG at fs/ext4/mballoc.c:1721!

[Sachin Sant <sachinp@in.ibm.com>]

Aneesh Kumar K.V wrote:
> Can you try this patch ?
>   
Thanks for the patch Aneesh.

I have executed the tests several times against this patch 
and haven't seen this issue. So at this point the patch looks good.

Tested-by : Sachin Sant <sachinp@in.ibm.com>

Will execute the tests few times more just to be doubly sure about this.

Thanks
-Sachin

> commit 43149bc800a6ae88b7d984558403e8d8cb045138
> Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Date:   Thu Sep 3 16:47:27 2009 +0530
>
>     ext4: check for good group with alloc_sem held
>     
>     We need to make sure we check for good group with alloc_sem
>     held to make sure we prevent a parallel addition of new blocks
>     to the group via resize.
>     
>     Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index cd25846..4623555 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2029,13 +2029,6 @@ repeat:
>  					goto out;
>  			}
>
> -			/*
> -			 * If the particular group doesn't satisfy our
> -			 * criteria we continue with the next group
> -			 */
> -			if (!ext4_mb_good_group(ac, group, cr))
> -				continue;
> -
>  			err = ext4_mb_load_buddy(sb, group, &e4b);
>  			if (err)
>  				goto out;
>   


-- 

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------