qt4-embedded & tslib

qt4-embedded & tslib

[Eric Bénard]

Hi,

in order to get gt4-embedded working with tslib, I had to do the 
following change.
Without this, tslib loads properly the module_raw (input in my case) but 
none of the module (pthres, linear & co) defined in ts.conf (despite the 
fact ts_test & co are running fine).

Eric

diff --git a/recipes/qt4/qt4-embedded.inc b/recipes/qt4/qt4-embedded.inc
index 95b770a..91b2a6b 100644
--- a/recipes/qt4/qt4-embedded.inc
+++ b/recipes/qt4/qt4-embedded.inc
@@ -4,7 +4,7 @@ LICENSE = "GPL QPL"
  PRIORITY = "optional"
  HOMEPAGE = "http://www.trolltech.com"
  DEPENDS += "directfb tslib"
-INC_PR = "r14"
+INC_PR = "r15"

  QT_BASE_NAME ?= "qt4-embedded"
  QT_BASE_LIB  ?= "libqt-embedded"
@@ -30,7 +30,7 @@ QT_CONFIG_FLAGS += " \
      -qtlibinfix ${QT_LIBINFIX} \
      -qt-decoration-styled -plugin-decoration-default 
-plugin-decoration-windows \
      -plugin-gfx-transformed -plugin-gfx-qvfb -plugin-gfx-vnc 
-plugin-gfx-directfb \
-    -plugin-mouse-tslib -qt-mouse-pc -qt-mouse-qvfb \
+    -qt-mouse-tslib -qt-mouse-pc -qt-mouse-qvfb \
      -qt-kbd-tty -qt-kbd-usb -qt-kbd-qvfb \
      -DQT_KEYPAD_NAVIGATION \
      "

Re: qt4-embedded & tslib

[Holger Hans Peter Freyther]

On Sunday 06 September 2009 14:31:36 Eric Bénard wrote:
> Hi,
>
> in order to get gt4-embedded working with tslib, I had to do the
> following change.
> Without this, tslib loads properly the module_raw (input in my case) but
> none of the module (pthres, linear & co) defined in ts.conf (despite the
> fact ts_test & co are running fine).

Please google for the QWS_MOUSE_PROTO environement variable... tslib support 
is built as a plugin and Qt needs to be instructed to load it.

regards
	z.



PS: http://qt.nokia.com/doc/4.5/qt-embedded-envvars.html

Re: qt4-embedded & tslib

[Eric Bénard]

Holger Hans Peter Freyther a écrit :
> On Sunday 06 September 2009 14:31:36 Eric Bénard wrote:
>> Without this, tslib loads properly the module_raw (input in my case) but
>> none of the module (pthres, linear & co) defined in ts.conf (despite the
>> fact ts_test & co are running fine).
> 
> Please google for the QWS_MOUSE_PROTO environement variable... tslib support 
> is built as a plugin and Qt needs to be instructed to load it.
> 
of course, without this variable it's not loaded at all.
But even with this variable, it doesn't work for me with 
-plugin-mouse-tslib but works with -qt-mouse-tslib.
I tried :
tslib:/dev/input/event0 & tslib:/dev/input/touchscreen0

In fact, the module_raw (input) is properly loaded (which means QT was 
instructed by QWS_MOUSE_PROTO to use tslib and TSLIB_PLUGINDIR is 
properly set) but the other modules (pthres, linear & co) are not 
properly loaded (from what I saw with strace they are found, opened, and 
closed). If I comment out all the modules (not module_raw) from ts.conf 
everything is properly loaded but of course tslib gives raw values to QT 
so touchscreen is unusable.

Eric

Re: qt4-embedded & tslib

[Matthew Dombroski]

On 07/09/09 05:16, Eric Bénard wrote:
> Holger Hans Peter Freyther a écrit :
>> On Sunday 06 September 2009 14:31:36 Eric Bénard wrote:
>>> Without this, tslib loads properly the module_raw (input in my case) 
>>> but
>>> none of the module (pthres, linear & co) defined in ts.conf (despite 
>>> the
>>> fact ts_test & co are running fine).
>>
>> Please google for the QWS_MOUSE_PROTO environement variable... tslib 
>> support is built as a plugin and Qt needs to be instructed to load it.
>>
> of course, without this variable it's not loaded at all.
> But even with this variable, it doesn't work for me with 
> -plugin-mouse-tslib but works with -qt-mouse-tslib.
> I tried :
> tslib:/dev/input/event0 & tslib:/dev/input/touchscreen0
>
> In fact, the module_raw (input) is properly loaded (which means QT was 
> instructed by QWS_MOUSE_PROTO to use tslib and TSLIB_PLUGINDIR is 
> properly set) but the other modules (pthres, linear & co) are not 
> properly loaded (from what I saw with strace they are found, opened, 
> and closed). If I comment out all the modules (not module_raw) from 
> ts.conf everything is properly loaded but of course tslib gives raw 
> values to QT so touchscreen is unusable.
>
> Eric

Actually, the problem is that tslib is linked incorrectly.
The pthres, linear, etc. modules are not linked to libts so theyre 
missing symbols when an attempt is made to load them.
To confirm, do

LD_PRELOAD=/usr/lib/libts-1.0.so.0 <args>

tslib modules will resolve symbols properly so tslib will work.

A quick patch to tslib to link those modules against libts is below.
A little dirty linking against the static libs, but it works!

Add to tslib_1.0.bb SRC_URI.

~Matt


--- tslib.orig/plugins/Makefile.am
+++ tslib/plugins/Makefile.am
@@ -107,15 +107,19 @@ pluginexec_LTLIBRARIES = \

  variance_la_SOURCES    = variance.c
  variance_la_LDFLAGS    = -module $(LTVSN)
+variance_la_LIBADD     = $(top_builddir)/src/libts.la

  dejitter_la_SOURCES    = dejitter.c
  dejitter_la_LDFLAGS    = -module $(LTVSN)
+dejitter_la_LIBADD     = $(top_builddir)/src/libts.la

  linear_la_SOURCES      = linear.c
  linear_la_LDFLAGS      = -module $(LTVSN)
+linear_la_LIBADD       = $(top_builddir)/src/libts.la

  pthres_la_SOURCES      = pthres.c
  pthres_la_LDFLAGS      = -module $(LTVSN)
+pthres_la_LIBADD       = $(top_builddir)/src/libts.la

  # hw access
  corgi_la_SOURCES       = corgi-raw.c

Re: qt4-embedded & tslib

[Eric Bénard]

Hi Matthew,

Matthew Dombroski a écrit :
> Actually, the problem is that tslib is linked incorrectly.
> The pthres, linear, etc. modules are not linked to libts so theyre 
> missing symbols when an attempt is made to load them.

ts_calibrate & ts_test are working fine : doesn't is mean the modules 
are properly linked ?

> To confirm, do
> 
> LD_PRELOAD=/usr/lib/libts-1.0.so.0 <args>
> 
> tslib modules will resolve symbols properly so tslib will work.
> 
I'll try this and tell you the result.

Thanks
Eric

Re: qt4-embedded & tslib

[Matthew Dombroski]

On 09/09/09 18:49, Eric Bénard wrote:
> Hi Matthew,
>
> Matthew Dombroski a écrit :
>> Actually, the problem is that tslib is linked incorrectly.
>> The pthres, linear, etc. modules are not linked to libts so theyre 
>> missing symbols when an attempt is made to load them.
>
> ts_calibrate & ts_test are working fine : doesn't is mean the modules 
> are properly linked ?

ldd says not:

$ ldd dejitter.so
libc.so.6 => /lib/libc.so.6 (0x4000a000)
/lib/ld-linux.so.3 (0x2a000000)

With my patch:

$ ldd dejitter.so
libts-1.0.so.0 => /usr/lib/libts-1.0.so.0 (0x4000a000)
libdl.so.2 => /lib/libdl.so.2 (0x40014000)
libc.so.6 => /lib/libc.so.6 (0x4001f000)
/lib/ld-linux.so.3

I'm not sure why Qt is the only place it fails (unlinked).
My opinion is that linking properly is technically better.

~Matt

Re: qt4-embedded & tslib

[Holger Hans Peter Freyther]

On Thursday 10 September 2009 00:02:07 Matthew Dombroski wrote:
> On 09/09/09 18:49, Eric Bénard wrote:
> > Hi Matthew,
> >
> > Matthew Dombroski a écrit :
> >> Actually, the problem is that tslib is linked incorrectly.
> >> The pthres, linear, etc. modules are not linked to libts so theyre
> >> missing symbols when an attempt is made to load them.
> >
> > ts_calibrate & ts_test are working fine : doesn't is mean the modules
> > are properly linked ?
>
> ldd says not:
>
> $ ldd dejitter.so
> libc.so.6 => /lib/libc.so.6 (0x4000a000)
> /lib/ld-linux.so.3 (0x2a000000)
>
> With my patch:
>
> $ ldd dejitter.so
> libts-1.0.so.0 => /usr/lib/libts-1.0.so.0 (0x4000a000)
> libdl.so.2 => /lib/libdl.so.2 (0x40014000)
> libc.so.6 => /lib/libc.so.6 (0x4001f000)
> /lib/ld-linux.so.3
>
> I'm not sure why Qt is the only place it fails (unlinked).
> My opinion is that linking properly is technically better.


Can you provide us with the output of the failure?

Re: qt4-embedded & tslib

[Matthew Dombroski]

On 10/09/09 14:12, Holger Hans Peter Freyther wrote:
> On Thursday 10 September 2009 00:02:07 Matthew Dombroski wrote:
>    
>> On 09/09/09 18:49, Eric Bénard wrote:
>>      
>>> Hi Matthew,
>>>
>>> Matthew Dombroski a écrit :
>>>        
>>>> Actually, the problem is that tslib is linked incorrectly.
>>>> The pthres, linear, etc. modules are not linked to libts so theyre
>>>> missing symbols when an attempt is made to load them.
>>>>          
>>> ts_calibrate&  ts_test are working fine : doesn't is mean the modules
>>> are properly linked ?
>>>        
>> ldd says not:
>>
>> $ ldd dejitter.so
>> libc.so.6 =>  /lib/libc.so.6 (0x4000a000)
>> /lib/ld-linux.so.3 (0x2a000000)
>>
>> With my patch:
>>
>> $ ldd dejitter.so
>> libts-1.0.so.0 =>  /usr/lib/libts-1.0.so.0 (0x4000a000)
>> libdl.so.2 =>  /lib/libdl.so.2 (0x40014000)
>> libc.so.6 =>  /lib/libc.so.6 (0x4001f000)
>> /lib/ld-linux.so.3
>>
>> I'm not sure why Qt is the only place it fails (unlinked).
>> My opinion is that linking properly is technically better.
>>      

Hmm... tslib svn has fixed it anyway.
See 
http://svn.berlios.de/viewcvs/tslib/trunk/tslib/plugins/Makefile.am?revision=56&view=markup

> Can you provide us with the output of the failure?
>    

runtime failure:

# app  -qws
Couldnt load module pthres
QWSTslibMouseHandlerPrivate: ts_config() failed with error: 'No such 
file or directory'
Please check your tslib installation!

My tslib installation is fine.

~Matt

Re: qt4-embedded & tslib

[Eric Bénard]

Matthew Dombroski a écrit :
> On 10/09/09 14:12, Holger Hans Peter Freyther wrote:
>> Can you provide us with the output of the failure?
>>    
> 
> runtime failure:
> 
> # app  -qws
> Couldnt load module pthres
> QWSTslibMouseHandlerPrivate: ts_config() failed with error: 'No such 
> file or directory'
> Please check your tslib installation!
> 
same thing here. I'll send you the strace later.

Eric

[PATCH] qt4-embedded & tslib

[Eric Bénard]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Hi,

Matthew Dombroski wrote :
> Actually, the problem is that tslib is linked incorrectly.
> The pthres, linear, etc. modules are not linked to libts so theyre 
> missing symbols when an attempt is made to load them.
> To confirm, do
> 
> LD_PRELOAD=/usr/lib/libts-1.0.so.0 <args>
> 
> tslib modules will resolve symbols properly so tslib will work.
> 
> A quick patch to tslib to link those modules against libts is below.
> A little dirty linking against the static libs, but it works!
> 
in fact, the patch you sent on the list was integrated into tslib in 
november 2008 :
http://svn.berlios.de/viewcvs/tslib/trunk/tslib/plugins/Makefile.am?r1=51&r2=56

Please find attached a patch to add this patch to the tslib's recipe.

Best regards
Eric

[-- Attachment #2: tslib.patch --]
[-- Type: text/x-patch, Size: 1893 bytes --]

diff --git a/recipes/tslib/tslib/tslib-pluginsld.patch b/recipes/tslib/tslib/tslib-pluginsld.patch
new file mode 100644
index 0000000..37ef808
--- /dev/null
+++ b/recipes/tslib/tslib/tslib-pluginsld.patch
@@ -0,0 +1,36 @@
+ plugins/Makefile.am |    5 +++++
+ 1 files changed, 5 insertions(+), 0 deletions(-)
+
+diff --git a/plugins/Makefile.am b/plugins/Makefile.am
+index 3b902c2..4c4ef8b 100644
+--- a/plugins/Makefile.am
++++ b/plugins/Makefile.am
+@@ -114,15 +114,19 @@ pluginexec_LTLIBRARIES = \
+   
+ variance_la_SOURCES	= variance.c
+ variance_la_LDFLAGS	= -module $(LTVSN)
++variance_la_LIBADD	= $(top_builddir)/src/libts.la
+   
+ dejitter_la_SOURCES	= dejitter.c
+ dejitter_la_LDFLAGS	= -module $(LTVSN)
++dejitter_la_LIBADD	= $(top_builddir)/src/libts.la
+   
+ linear_la_SOURCES	= linear.c
+ linear_la_LDFLAGS	= -module $(LTVSN)
++linear_la_LIBADD	= $(top_builddir)/src/libts.la
+ 
+ pthres_la_SOURCES	= pthres.c
+ pthres_la_LDFLAGS	= -module $(LTVSN)
++pthres_la_LIBADD	= $(top_builddir)/src/libts.la
+ 
+ # hw access
+ corgi_la_SOURCES	= corgi-raw.c
+@@ -148,6 +152,7 @@ tatung_la_LDFLAGS	= -module $(LTVSN)
+ 
+ input_la_SOURCES	= input-raw.c
+ input_la_LDFLAGS	= -module $(LTVSN)
++input_la_LIBADD	  = $(top_builddir)/src/libts.la
+ 
+ linear_h2200_la_SOURCES	= linear-h2200.c
+ linear_h2200_la_LDFLAGS	= -module $(LTVSN)
+
diff --git a/recipes/tslib/tslib_1.0.bb b/recipes/tslib/tslib_1.0.bb
index 1929ee0..bbd4793 100644
--- a/recipes/tslib/tslib_1.0.bb
+++ b/recipes/tslib/tslib_1.0.bb
@@ -1,6 +1,7 @@
 SRC_URI = "http://download.berlios.de/tslib/${BP}.tar.bz2 \
            file://fix_version.patch;patch=1 \
-           file://tslib-nopressure.patch;patch=1"
-PR = "${INC_PR}.2"
+           file://tslib-nopressure.patch;patch=1 \
+	   file://tslib-pluginsld.patch;patch=1"
+PR = "${INC_PR}.3"
 
 include tslib.inc

Re: [PATCH] qt4-embedded & tslib

[Holger Hans Peter Freyther]

On Thursday 24 September 2009 21:02:10 Eric Bénard wrote:
> Hi,
> 
> Matthew Dombroski wrote :
> > Actually, the problem is that tslib is linked incorrectly.
> > The pthres, linear, etc. modules are not linked to libts so theyre
> > missing symbols when an attempt is made to load them.
> > To confirm, do
> >
> > LD_PRELOAD=/usr/lib/libts-1.0.so.0 <args>
> >
> > tslib modules will resolve symbols properly so tslib will work.
> >
> > A quick patch to tslib to link those modules against libts is below.
> > A little dirty linking against the static libs, but it works!
> 
> in fact, the patch you sent on the list was integrated into tslib in
> november 2008 :
> http://svn.berlios.de/viewcvs/tslib/trunk/tslib/plugins/Makefile.am?r1=51&r
> 2=56
> 
> Please find attached a patch to add this patch to the tslib's recipe.
> 
> Best regards
> Eric
> 

Signed-off-by: Holger Hans Peter Freyther <zecke@selfish.org>


PS: This will be unlikely tracked by patchwork. Could you try in the future to 
send a patch from git format-patch and add a signed-off-by line so landing the 
patch will be more easy.

Re: [PATCH] qt4-embedded & tslib

[Eric Bénard]

Holger Hans Peter Freyther a écrit :
> PS: This will be unlikely tracked by patchwork. Could you try in the future to 
> send a patch from git format-patch and add a signed-off-by line so landing the 
> patch will be more easy.
> 
OK I'll do for the next patch

Thanks,
Eric