All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx
Date: Tue, 08 Sep 2009 17:13:55 -0400	[thread overview]
Message-ID: <4AA6C913.7000004@ge.com> (raw)
In-Reply-To: <20090908204114.E79F9832E8DE@gemini.denx.de>

Wolfgang Denk wrote:
> Dear "J.C. Wren",
> 
> In message <17434f2e0909081312r3fe4523ej66ed4fc0275fa148@mail.gmail.com> you wrote:
>> Excellent explanation.  Thank you.
> 
> Indeed. Thanks to gvb.
> 
> I'd just like to add that you also never know if SZ_1M is 1024*1024 or 1000*1000.
> 
>> I do like this (from the email link): (31 * 1024 * 1024).  And it appears
>> not to give Wolfgang indigestion :)
> 
> It is probably the preferred form in many cases, line length
> permitting :-) "31 << 20" is a bit shorter, but it's just a personal

s/3// ;-)

> preference, not something I consider better in any way.
> 
> Best regards,
> 
> Wolfgang Denk

Another objection: Company A makes their favorite SZ_* defines but 
Company B defines them as SIZE_* but Company C defines them as...

...and we end up with the same mess as INT32 vs. WORD vs. int32_t 
defines (C99 tackled that, finally, but not all the mess has been 
cleaned up yet, 10 years later).

Best regards,
gvb

  reply	other threads:[~2009-09-08 21:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-08 18:24 [U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx s-paulraj at ti.com
2009-09-08 18:50 ` Wolfgang Denk
2009-09-08 18:56   ` Paulraj, Sandeep
2009-09-08 19:04     ` Paulraj, Sandeep
2009-09-08 20:34       ` Wolfgang Denk
2009-09-08 19:09     ` Tom
2009-09-08 19:14       ` J.C. Wren
2009-09-08 19:20         ` Paulraj, Sandeep
2009-09-08 19:28           ` J.C. Wren
2009-09-08 19:38             ` Paulraj, Sandeep
2009-09-08 20:07             ` Jerry Van Baren
2009-09-08 20:12               ` J.C. Wren
2009-09-08 20:41                 ` Wolfgang Denk
2009-09-08 21:13                   ` Jerry Van Baren [this message]
2009-09-08 21:21                     ` Wolfgang Denk
2009-09-09  2:45                       ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA6C913.7000004@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.