From: Avi Kivity <avi@redhat.com>
To: Julia Lawall <julia@diku.dk>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/9] virt/kvm: correct error-handling code
Date: Wed, 09 Sep 2009 14:42:19 +0000 [thread overview]
Message-ID: <4AA7BECB.2090903@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0907281752560.28189@ask.diku.dk>
On 07/28/2009 06:53 PM, Julia Lawall wrote:
> From: Julia Lawall<julia@diku.dk>
>
> This code is not executed before file has been initialized to the result of
> calling eventfd_fget. This function returns an ERR_PTR value in an error
> case instead of NULL. Thus the test that file is not NULL is always true.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //<smpl>
> @match exists@
> expression x, E;
> statement S1, S2;
> @@
>
> x = eventfd_fget(...)
> ... when != x = E
> (
> * if (x = NULL || ...) S1 else S2
> |
> * if (x = NULL&& ...) S1 else S2
> )
> //</smpl>
>
>
Applied, thanks (yes, old patch, missed it).
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Julia Lawall <julia@diku.dk>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/9] virt/kvm: correct error-handling code
Date: Wed, 09 Sep 2009 17:42:19 +0300 [thread overview]
Message-ID: <4AA7BECB.2090903@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0907281752560.28189@ask.diku.dk>
On 07/28/2009 06:53 PM, Julia Lawall wrote:
> From: Julia Lawall<julia@diku.dk>
>
> This code is not executed before file has been initialized to the result of
> calling eventfd_fget. This function returns an ERR_PTR value in an error
> case instead of NULL. Thus the test that file is not NULL is always true.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //<smpl>
> @match exists@
> expression x, E;
> statement S1, S2;
> @@
>
> x = eventfd_fget(...)
> ... when != x = E
> (
> * if (x == NULL || ...) S1 else S2
> |
> * if (x == NULL&& ...) S1 else S2
> )
> //</smpl>
>
>
Applied, thanks (yes, old patch, missed it).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-09-09 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 15:53 [PATCH 3/9] virt/kvm: correct error-handling code Julia Lawall
2009-07-28 15:53 ` Julia Lawall
2009-09-09 14:42 ` Avi Kivity [this message]
2009-09-09 14:42 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA7BECB.2090903@redhat.com \
--to=avi@redhat.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.