Re: [PATCH] e2fsprogs: clean up ext2fs_bg_flags_ interfaces

[Eric Sandeen <sandeen@redhat.com>]

Nick Dokos wrote:
>> ...  				}
>> diff --git a/e2fsck/super.c b/e2fsck/super.c
>> index 409d472..b8eee6b 100644
>> --- a/e2fsck/super.c
>> +++ b/e2fsck/super.c
>> @@ -637,8 +637,8 @@ void check_super_block(e2fsck_t ctx)
>>  		should_be = 0;
>>  		if (!ext2fs_group_desc_csum_verify(fs, i)) {
>>  			if (fix_problem(ctx, PR_0_GDT_CSUM, &pctx)) {
>> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_BLOCK_UNINIT);
>> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_INODE_UNINIT);
>> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_BLOCK_UNINIT);
>> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_INODE_UNINIT);
>>  				ext2fs_bg_itable_unused_set(fs, i, 0);
>>  				should_be = 1;
>>  			}
> 
> Wouldn't something like this be better? There are a few places where this
> could be done:

thought about that, but it goes over 80cols and only a couple places, 
*shrug*

-Eric

> 
>> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_BLOCK_UNINIT);
>> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_INODE_UNINIT);
>> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_BLOCK_UNINIT | EXT2_BG_INODE_UNINIT);
> 
> 
> Thanks,
> Nick