All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Cc: nicholas.dokos@hp.com
Subject: Re: [PATCH] e2fsprogs: clean up ext2fs_bg_flags_ interfaces
Date: Wed, 09 Sep 2009 15:19:24 -0400	[thread overview]
Message-ID: <8893.1252523964@alphaville.usa.hp.com> (raw)
In-Reply-To: Message from Eric Sandeen <sandeen@redhat.com> of "Wed, 09 Sep 2009 14:03:47 CDT." <4AA7FC13.6060109@redhat.com>

> ...  				}
> diff --git a/e2fsck/super.c b/e2fsck/super.c
> index 409d472..b8eee6b 100644
> --- a/e2fsck/super.c
> +++ b/e2fsck/super.c
> @@ -637,8 +637,8 @@ void check_super_block(e2fsck_t ctx)
>  		should_be = 0;
>  		if (!ext2fs_group_desc_csum_verify(fs, i)) {
>  			if (fix_problem(ctx, PR_0_GDT_CSUM, &pctx)) {
> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_BLOCK_UNINIT);
> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_INODE_UNINIT);
> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_BLOCK_UNINIT);
> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_INODE_UNINIT);
>  				ext2fs_bg_itable_unused_set(fs, i, 0);
>  				should_be = 1;
>  			}

Wouldn't something like this be better? There are a few places where this
could be done:


> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_BLOCK_UNINIT);
> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_INODE_UNINIT);
> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_BLOCK_UNINIT | EXT2_BG_INODE_UNINIT);


Thanks,
Nick

  reply	other threads:[~2009-09-09 19:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-09 19:03 [PATCH] e2fsprogs: clean up ext2fs_bg_flags_ interfaces Eric Sandeen
2009-09-09 19:19 ` Nick Dokos [this message]
2009-09-09 19:26   ` Eric Sandeen
2009-10-05 11:51 ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8893.1252523964@alphaville.usa.hp.com \
    --to=nicholas.dokos@hp.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.