From: "H. Peter Anvin" <hpa@zytor.com>
To: Jack Steiner <steiner@sgi.com>
Cc: Chris Friesen <cfriesen@nortel.com>,
Daniel Walker <dwalker@fifo99.com>,
mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: SGU UV Add volatile to macros that access chipset registers
Date: Wed, 09 Sep 2009 17:44:23 -0700 [thread overview]
Message-ID: <4AA84BE7.9010304@zytor.com> (raw)
In-Reply-To: <20090909193829.GB10530@sgi.com>
On 09/09/2009 12:38 PM, Jack Steiner wrote:
>
> static inline void uv_write_local_mmr8(unsigned long offset, unsigned char val)
> {
> - *((unsigned char *)uv_local_mmr_address(offset)) = val;
> + *((volatile unsigned char *)uv_local_mmr_address(offset)) = val;
> }
>
Why aren't you simply using __writeb() here, and the other memory
accessors we already have in the other places?
-hpa
next prev parent reply other threads:[~2009-09-10 0:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 15:42 [PATCH] x86: SGU UV Add volatile to macros that access chipset registers Jack Steiner
2009-09-09 16:10 ` Daniel Walker
2009-09-09 18:01 ` Jack Steiner
2009-09-09 18:11 ` Daniel Walker
2009-09-09 18:54 ` Chris Friesen
2009-09-09 19:38 ` Jack Steiner
2009-09-10 0:44 ` H. Peter Anvin [this message]
2009-09-10 2:21 ` Jack Steiner
2009-09-10 2:22 ` [PATCH V2] x86: SGU UV Add volatile semantics " Jack Steiner
2009-09-10 3:05 ` H. Peter Anvin
2009-09-10 3:23 ` Jack Steiner
2009-09-10 14:31 ` [PATCH V3] " Jack Steiner
2009-09-10 14:31 ` Jack Steiner
2009-09-18 12:06 ` [tip:x86/urgent] x86: SGI UV: " tip-bot for Jack Steiner
2009-09-09 19:20 ` [PATCH] x86: SGU UV Add volatile " Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA84BE7.9010304@zytor.com \
--to=hpa@zytor.com \
--cc=cfriesen@nortel.com \
--cc=dwalker@fifo99.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.