From: Timur Tabi <timur@freescale.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org,
Andy Fleming <afleming@freescale.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/3] ucc_geth: Rearrange some code to avoid forward declarations
Date: Thu, 10 Sep 2009 08:00:48 -0500 [thread overview]
Message-ID: <4AA8F880.1000300@freescale.com> (raw)
In-Reply-To: <20090910020140.GB31083@oksana.dev.rtsoft.ru>
Anton Vorontsov wrote:
> We'll need ugeth_disable() and ugeth_enable() calls earlier in the
> file, so rearrange some code to avoid forward declarations.
>
> The patch doesn't contain any functional changes.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: Timur Tabi <timur@freescale.com>
I'm generally not qualified to review ucc_geth patches, but I'm in favor of this one. I hate forward declarations.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: David Miller <davem@davemloft.net>,
Andy Fleming <afleming@freescale.com>,
Li Yang <leoli@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>,
netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/3] ucc_geth: Rearrange some code to avoid forward declarations
Date: Thu, 10 Sep 2009 08:00:48 -0500 [thread overview]
Message-ID: <4AA8F880.1000300@freescale.com> (raw)
In-Reply-To: <20090910020140.GB31083@oksana.dev.rtsoft.ru>
Anton Vorontsov wrote:
> We'll need ugeth_disable() and ugeth_enable() calls earlier in the
> file, so rearrange some code to avoid forward declarations.
>
> The patch doesn't contain any functional changes.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: Timur Tabi <timur@freescale.com>
I'm generally not qualified to review ucc_geth patches, but I'm in favor of this one. I hate forward declarations.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-09-10 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 2:01 [PATCH 2/3] ucc_geth: Rearrange some code to avoid forward declarations Anton Vorontsov
2009-09-10 2:01 ` Anton Vorontsov
2009-09-10 13:00 ` Timur Tabi [this message]
2009-09-10 13:00 ` Timur Tabi
2009-09-11 19:19 ` David Miller
2009-09-11 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA8F880.1000300@freescale.com \
--to=timur@freescale.com \
--cc=afleming@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.