Re: [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained?

[Avi Kivity <avi@redhat.com>]

On 09/10/2009 06:54 PM, Anthony Liguori wrote:
> Avi Kivity wrote:
>> On 09/10/2009 04:56 PM, Anthony Liguori wrote:
>>>
>>> The problem is patch volume.  We often see hundreds of patches a 
>>> day.  If typing a mail for each patch takes 2 minutes, that's 
>>> potentially hours spent just on sending these mails.
>>>
>>
>> You exaggerate.  The average rate is 13 patches per calendar day.
>
> On list or committed?  There are a lot more on list than 13..

You certainly shouldn't ack patches you don't commit!

>
>> commit e09a5267adf0af25b55d2abaf06e288b2d9537ea
>> Author: Dustin Kirkland <kirkland@canonical.com>
>> Date:   Thu Sep 3 12:31:33 2009 -0500
>>
>>     qemu-kvm: fix segfault when running kvm without /dev/kvm, falling 
>> back to non-accelerated mode
>>
>>     qemu-kvm: fix segfault when running kvm without /dev/kvm, falling 
>> back
>>     to non-accelerated mode
>>
>>     We're seeing segfaults on systems without access to /dev/kvm.  It
>>     looks like the global kvm_allowed is being set just a little too 
>> late
>>     in vl.c.  This patch moves the kvm initialization a bit higher in 
>> the
>>     vl.c main, just after options processing, and solves the segfaults.
>>     We're carrying this patch in Ubuntu 9.10 Alpha.  Please apply
>>     upstream, or advise if and why this might not be the optimal 
>> solution.
>>
>>     Signed-off-by: Dustin Kirkland <kirkland@canonical.com>
>>
>>     Move the kvm_init() call a bit higher to fix a segfault when
>>     /dev/kvm is not available.  The kvm_allowed global needs
>>     to be set correctly a little earlier.
>>
>>     Signed-off-by: Dustin Kirkland <kirkland@canonical.com>
>>     Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>
>> There are many examples like this in the tree which is a pity.  
>> Others include parts of an email conversation.  I'd like history to 
>> look better than this.
>
> This is goofy and is caused by improper patch submission.  But when 
> people quote email threads in a commit message, I don't remove them.  
> It don't see it as a problem.

 From long experience, most commit messages need to be edited.  People 
rarely write commit messages that can be understood a year later, and 
they don't know how 'git am' works.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.