Re: [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained?

[Anthony Liguori <anthony@codemonkey.ws>]

Avi Kivity wrote:
> On 09/10/2009 07:22 PM, Anthony Liguori wrote:
>>> You certainly shouldn't ack patches you don't commit!
>>
>>
>> But most spend time in staging.
>
> What's the percentage of patches that make it to master?  For me it's 
> >90%.  If it's too low we nned to fix that.

Closer to 20% I'd say.  This is largely due to multiple versions of the 
same series.  If there's a way to improve this, that would make my life 
a lot easier.

>> I don't like editing patches.  I think it's unfair to the submitter 
>> to change their patch underneath of them.  I'd suggest providing 
>> feedback on the list to people who write bad commit messages and ask 
>> them to write better ones.  I try to limit the changes I make to 
>> resolving merge conflicts.
>
> Editing the commit log is not changing the patch.  I doubt you'll be 
> able to get better commit messages - submitters have more immediate 
> perspectives than maintainers (should have).  I always try to make the 
> log make sense a year from now (the code may change, but the commit 
> log won't).
>
> Unfairly picking on Mark (who usually writes truly excellent 
> changelogs, but this one is such a gem):
>
>> Subject: [Qemu-devel] [PATCH 01/19] Suppress more more kraxelism
>>
>> Let's kick off this series with some of the more critical fixes.
>>
>> Signed-off-by: Mark McLoughlin<markmc@redhat.com>
>>    
>
> What would you be thinking hunting the commit log for some change and 
> coming up with this?

Well the question is, should I/you edit this, or reject the patch 
requesting a better changelog?

Certainly, the later is what akpm often does.

Regards,

Anthony Liguori