From: Scott Wood <scottwood@freescale.com>
To: avorontsov@ru.mvista.com
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
Andy Fleming <afleming@freescale.com>,
David Miller <davem@davemloft.net>,
Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH v2 3/3] ucc_geth: Fix hangs after switching from full to half duplex
Date: Thu, 10 Sep 2009 13:04:32 -0500 [thread overview]
Message-ID: <4AA93FB0.5060802@freescale.com> (raw)
In-Reply-To: <20090910175852.GA18948@oksana.dev.rtsoft.ru>
Anton Vorontsov wrote:
> MPC8360 QE UCC ethernet controllers hang when changing link duplex
> under a load (a bit of NFS activity is enough).
>
> PHY: mdio@e0102120:00 - Link is Up - 1000/Full
> sh-3.00# ethtool -s eth0 speed 100 duplex half autoneg off
> PHY: mdio@e0102120:00 - Link is Down
> PHY: mdio@e0102120:00 - Link is Up - 100/Half
> NETDEV WATCHDOG: eth0 (ucc_geth): transmit queue 0 timed out
> ------------[ cut here ]------------
> Badness at c01fcbd0 [verbose debug info unavailable]
> NIP: c01fcbd0 LR: c01fcbd0 CTR: c0194e44
> ...
>
> The cure is to disable the controller before changing speed/duplex
> and enable it afterwards.
>
> Since ugeth_graceful_stop_{tx,rx} now may be called from an atomic
> context, switch the two functions from msleep() to mdelay().
Ouch. Can we put this in a workqueue or something?
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: avorontsov@ru.mvista.com
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Andy Fleming <afleming@freescale.com>,
Timur Tabi <timur@freescale.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 3/3] ucc_geth: Fix hangs after switching from full to half duplex
Date: Thu, 10 Sep 2009 13:04:32 -0500 [thread overview]
Message-ID: <4AA93FB0.5060802@freescale.com> (raw)
In-Reply-To: <20090910175852.GA18948@oksana.dev.rtsoft.ru>
Anton Vorontsov wrote:
> MPC8360 QE UCC ethernet controllers hang when changing link duplex
> under a load (a bit of NFS activity is enough).
>
> PHY: mdio@e0102120:00 - Link is Up - 1000/Full
> sh-3.00# ethtool -s eth0 speed 100 duplex half autoneg off
> PHY: mdio@e0102120:00 - Link is Down
> PHY: mdio@e0102120:00 - Link is Up - 100/Half
> NETDEV WATCHDOG: eth0 (ucc_geth): transmit queue 0 timed out
> ------------[ cut here ]------------
> Badness at c01fcbd0 [verbose debug info unavailable]
> NIP: c01fcbd0 LR: c01fcbd0 CTR: c0194e44
> ...
>
> The cure is to disable the controller before changing speed/duplex
> and enable it afterwards.
>
> Since ugeth_graceful_stop_{tx,rx} now may be called from an atomic
> context, switch the two functions from msleep() to mdelay().
Ouch. Can we put this in a workqueue or something?
-Scott
next prev parent reply other threads:[~2009-09-10 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 2:01 [PATCH 3/3] ucc_geth: Fix hangs after switching from full to half duplex Anton Vorontsov
2009-09-10 2:01 ` Anton Vorontsov
2009-09-10 17:58 ` [PATCH v2 " Anton Vorontsov
2009-09-10 17:58 ` Anton Vorontsov
2009-09-10 18:04 ` Scott Wood [this message]
2009-09-10 18:04 ` Scott Wood
2009-09-10 19:40 ` Anton Vorontsov
2009-09-10 19:40 ` Anton Vorontsov
2009-09-10 21:09 ` Anton Vorontsov
2009-09-10 21:09 ` Anton Vorontsov
2009-09-10 21:48 ` [PATCH v3 " Anton Vorontsov
2009-09-10 21:48 ` Anton Vorontsov
2009-09-11 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA93FB0.5060802@freescale.com \
--to=scottwood@freescale.com \
--cc=afleming@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.