From: Danny Feng <dfeng@redhat.com>
To: Eric Paris <eparis@redhat.com>
Cc: cl@linux-foundation.org, penberg@cs.helsinki.fi, mingo@elte.hu,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [GIT BISECT] BUG kmalloc-8192: Object already free from kmem_cache_destroy
Date: Mon, 14 Sep 2009 09:52:57 +0800 [thread overview]
Message-ID: <4AADA1F9.9080305@redhat.com> (raw)
In-Reply-To: <1252883493.16335.8.camel@dhcp231-106.rdu.redhat.com>
On 09/14/2009 07:11 AM, Eric Paris wrote:
> On Sun, 2009-09-13 at 14:33 -0400, Eric Paris wrote:
>> 2a38a002fbee06556489091c30b04746222167e4 is first bad commit
>> commit 2a38a002fbee06556489091c30b04746222167e4
>> Author: Xiaotian Feng<dfeng@redhat.com>
>> Date: Wed Jul 22 17:03:57 2009 +0800
>>
>> slub: sysfs_slab_remove should free kmem_cache when debug is enabled
>>
>> kmem_cache_destroy use sysfs_slab_remove to release the kmem_cache,
>> but when CONFIG_SLUB_DEBUG is enabled, sysfs_slab_remove just release
>> related kobject, the whole kmem_cache is missed to release and cause
>> a memory leak.
>>
>> Acked-by: Christoph Lameer<cl@linux-foundation.org>
>> Signed-off-by: Xiaotian Feng<dfeng@redhat.com>
>> Signed-off-by: Pekka Enberg<penberg@cs.helsinki.fi>
>>
>> CONFIG_SLUB_DEBUG=y
>> CONFIG_SLUB=y
>> CONFIG_SLUB_DEBUG_ON=y
>> # CONFIG_SLUB_STATS is not set
>
> I also had problems destroying a kmem_cache in a security_initcall()
> function which had a different backtrace (it's what made me create the
> module and bisect.) So be sure to let me know what you find so I can
> be sure that we fix that place as well (I believe that was a kref
> problem rather than a double free)
>
> -Eric
>
>
Could you please tell me the tree you're using? I'll debug on it first...
WARNING: multiple messages have this Message-ID (diff)
From: Danny Feng <dfeng@redhat.com>
To: Eric Paris <eparis@redhat.com>
Cc: cl@linux-foundation.org, penberg@cs.helsinki.fi, mingo@elte.hu,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [GIT BISECT] BUG kmalloc-8192: Object already free from kmem_cache_destroy
Date: Mon, 14 Sep 2009 09:52:57 +0800 [thread overview]
Message-ID: <4AADA1F9.9080305@redhat.com> (raw)
In-Reply-To: <1252883493.16335.8.camel@dhcp231-106.rdu.redhat.com>
On 09/14/2009 07:11 AM, Eric Paris wrote:
> On Sun, 2009-09-13 at 14:33 -0400, Eric Paris wrote:
>> 2a38a002fbee06556489091c30b04746222167e4 is first bad commit
>> commit 2a38a002fbee06556489091c30b04746222167e4
>> Author: Xiaotian Feng<dfeng@redhat.com>
>> Date: Wed Jul 22 17:03:57 2009 +0800
>>
>> slub: sysfs_slab_remove should free kmem_cache when debug is enabled
>>
>> kmem_cache_destroy use sysfs_slab_remove to release the kmem_cache,
>> but when CONFIG_SLUB_DEBUG is enabled, sysfs_slab_remove just release
>> related kobject, the whole kmem_cache is missed to release and cause
>> a memory leak.
>>
>> Acked-by: Christoph Lameer<cl@linux-foundation.org>
>> Signed-off-by: Xiaotian Feng<dfeng@redhat.com>
>> Signed-off-by: Pekka Enberg<penberg@cs.helsinki.fi>
>>
>> CONFIG_SLUB_DEBUG=y
>> CONFIG_SLUB=y
>> CONFIG_SLUB_DEBUG_ON=y
>> # CONFIG_SLUB_STATS is not set
>
> I also had problems destroying a kmem_cache in a security_initcall()
> function which had a different backtrace (it's what made me create the
> module and bisect.) So be sure to let me know what you find so I can
> be sure that we fix that place as well (I believe that was a kref
> problem rather than a double free)
>
> -Eric
>
>
Could you please tell me the tree you're using? I'll debug on it first...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-09-14 1:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 18:33 [GIT BISECT] BUG kmalloc-8192: Object already free from kmem_cache_destroy Eric Paris
2009-09-13 18:33 ` Eric Paris
2009-09-13 23:11 ` Eric Paris
2009-09-13 23:11 ` Eric Paris
2009-09-14 1:52 ` Danny Feng [this message]
2009-09-14 1:52 ` Danny Feng
2009-09-14 3:13 ` Eric Paris
2009-09-14 3:13 ` Eric Paris
2009-09-14 3:41 ` Danny Feng
2009-09-14 3:41 ` Danny Feng
2009-09-14 6:27 ` Pekka Enberg
2009-09-14 6:27 ` Pekka Enberg
2009-09-14 3:18 ` Danny Feng
2009-09-14 3:18 ` Danny Feng
2009-09-14 3:25 ` Eric Paris
2009-09-14 3:25 ` Eric Paris
2009-09-14 3:29 ` Danny Feng
2009-09-14 3:29 ` Danny Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AADA1F9.9080305@redhat.com \
--to=dfeng@redhat.com \
--cc=cl@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.