From: Wolfgang Grandegger <wg@grandegger.com>
To: hs@denx.de
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] mpc5200: support for the MAN mpc5200 based board uc101
Date: Mon, 14 Sep 2009 21:16:22 +0200 [thread overview]
Message-ID: <4AAE9686.4060709@grandegger.com> (raw)
In-Reply-To: <4AAE4F44.7080300@denx.de>
Hello Heiko,
Heiko Schocher wrote:
> Hello Grant,
>
> Grant Likely wrote:
>> Thanks for the patch. Comments below.
>>
>> g.
>>
>> On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher <hs@denx.de> wrote:
>>> - serial Console on PSC1
>>> - 64MB SDRAM
>>> - MTD CFI Flash
>>> - Ethernet FEC
>>> - I2C with PCF8563 and Temp. Sensor ADM9240
>>> - IDE support
>>>
>>> Signed-off-by: Heiko Schocher <hs@denx.de>
...snip....
>>> + i2c@3d40 {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + compatible = "fsl,mpc5200-i2c","fsl-i2c";
>>> + reg = <0x3d40 0x40>;
>>> + interrupts = <2 16 0>;
>>> + fsl5200-clocking;
>> I believe fsl5200-clocking is no longer required. There is a patch
>> pending which removes this property from the other .dts files.
Right, it obsolete.
> Ok, fix this.
Like it is, the I2C controller will use a fixed low speed fdt/dfsr
setting. You have two other options:
fsl,preserve-clocking;
clock-frequency = <400000>;
See also
http://lxr.linux.no/#linux+v2.6.31/Documentation/powerpc/dts-bindings/fsl/i2c.txt.
>>> +
>>> + hwmon@2c {
>>> + compatible = "ad,adm9240";
>>> + reg = <0x2c>;
>>> + };
>>> + rtc@51 {
>>> + compatible = "rtc,pcf8563";
rtc is not a proper vendor name. Should be nxp, IIRC.
Wolfgang.
next prev parent reply other threads:[~2009-09-14 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 8:05 [PATCH] mpc5200: support for the MAN mpc5200 based board uc101 Heiko Schocher
2009-09-14 13:38 ` Grant Likely
2009-09-14 14:12 ` Heiko Schocher
2009-09-14 19:16 ` Wolfgang Grandegger [this message]
2009-09-15 5:06 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAE9686.4060709@grandegger.com \
--to=wg@grandegger.com \
--cc=hs@denx.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.