Re: [PATCH] mpc5200: support for the MAN mpc5200 based board uc101

[Heiko Schocher <hs@denx.de>]

Hello Wolfgang,

Wolfgang Grandegger wrote:
> Heiko Schocher wrote:
>> Hello Grant,
>>
>> Grant Likely wrote:
>>> Thanks for the patch.  Comments below.
>>>
>>> g.
>>>
>>> On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher <hs@denx.de> wrote:
>>>> - serial Console on PSC1
>>>> - 64MB SDRAM
>>>> - MTD CFI Flash
>>>> - Ethernet FEC
>>>> - I2C with PCF8563 and Temp. Sensor ADM9240
>>>> - IDE support
>>>>
>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
> ...snip....
> 
>>>> +               i2c@3d40 {
>>>> +                       #address-cells = <1>;
>>>> +                       #size-cells = <0>;
>>>> +                       compatible = "fsl,mpc5200-i2c","fsl-i2c";
>>>> +                       reg = <0x3d40 0x40>;
>>>> +                       interrupts = <2 16 0>;
>>>> +                       fsl5200-clocking;
>>> I believe fsl5200-clocking is no longer required.  There is a patch
>>> pending which removes this property from the other .dts files.
> 
> Right, it obsolete.

OK, I remove it.

>> Ok, fix this.
> 
> Like it is, the I2C controller will use a fixed low speed fdt/dfsr
> setting. You have two other options:
> 
>   fsl,preserve-clocking;
>   clock-frequency = <400000>;
> 
> See also
> http://lxr.linux.no/#linux+v2.6.31/Documentation/powerpc/dts-bindings/fsl/i2c.txt.

Ah, ok, thanks for this info. I try this ...

>>>> +
>>>> +                       hwmon@2c {
>>>> +                               compatible = "ad,adm9240";
>>>> +                               reg = <0x2c>;
>>>> +                       };
>>>> +                       rtc@51 {
>>>> +                               compatible = "rtc,pcf8563";
> 
> rtc is not a proper vendor name. Should be nxp, IIRC.

OK, fix it.

Thanks for reviewing

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany