All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/7] ak4114 - fix errors in output selector bits
@ 2009-09-15 22:39 pavel.hofman
  2009-09-15 22:39 ` [PATCH 2/7] ak4620 support, codec regs listed in proc pavel.hofman
  2009-09-16  6:03 ` [PATCH 1/7] ak4114 - fix errors in output selector bits Takashi Iwai
  0 siblings, 2 replies; 19+ messages in thread
From: pavel.hofman @ 2009-09-15 22:39 UTC (permalink / raw)
  To: patch; +Cc: Pavel Hofman, alsa-devel

From: Pavel Hofman <pavel.hofman@ivitera.com>


Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>

diff --git a/include/ak4114.h b/include/ak4114.h
index d293d36..3ce69fd 100644
--- a/include/ak4114.h
+++ b/include/ak4114.h
@@ -95,13 +95,13 @@
 
 /* AK4114_REG_IO0 */
 #define AK4114_TX1E		(1<<7)	/* TX1 Output Enable (1 = enable) */
-#define AK4114_OPS12		(1<<2)	/* Output Though Data Selector for TX1 pin */
-#define AK4114_OPS11		(1<<1)	/* Output Though Data Selector for TX1 pin */
-#define AK4114_OPS10		(1<<0)	/* Output Though Data Selector for TX1 pin */
+#define AK4114_OPS12		(1<<6)	/* Output Data Selector for TX1 pin */
+#define AK4114_OPS11		(1<<5)	/* Output Data Selector for TX1 pin */
+#define AK4114_OPS10		(1<<4)	/* Output Data Selector for TX1 pin */
 #define AK4114_TX0E		(1<<3)	/* TX0 Output Enable (1 = enable) */
-#define AK4114_OPS02		(1<<2)	/* Output Though Data Selector for TX0 pin */
-#define AK4114_OPS01		(1<<1)	/* Output Though Data Selector for TX0 pin */
-#define AK4114_OPS00		(1<<0)	/* Output Though Data Selector for TX0 pin */
+#define AK4114_OPS02		(1<<2)	/* Output Data Selector for TX0 pin */
+#define AK4114_OPS01		(1<<1)	/* Output Data Selector for TX0 pin */
+#define AK4114_OPS00		(1<<0)	/* Output Data Selector for TX0 pin */
 
 /* AK4114_REG_IO1 */
 #define AK4114_EFH1		(1<<7)	/* Interrupt 0 pin Hold */
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 19+ messages in thread
* [PATCH 1/7] ak4114 - fix errors in output selector bits
@ 2009-09-16 20:25 pavel.hofman
  2009-09-16 20:25 ` [PATCH 2/7] ak4620 support, codec regs listed in proc pavel.hofman
  0 siblings, 1 reply; 19+ messages in thread
From: pavel.hofman @ 2009-09-16 20:25 UTC (permalink / raw)
  To: patch; +Cc: Pavel Hofman, alsa-devel

From: Pavel Hofman <pavel.hofman@ivitera.com>

* the previous version had a typo - values of AK4114_OPS10-12 were
  identical with AK4114_OPS00-02
* Since no cards actually use this feature, the bug was not identified earlier

Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>

diff --git a/include/ak4114.h b/include/ak4114.h
index d293d36..3ce69fd 100644
--- a/include/ak4114.h
+++ b/include/ak4114.h
@@ -95,13 +95,13 @@
 
 /* AK4114_REG_IO0 */
 #define AK4114_TX1E		(1<<7)	/* TX1 Output Enable (1 = enable) */
-#define AK4114_OPS12		(1<<2)	/* Output Though Data Selector for TX1 pin */
-#define AK4114_OPS11		(1<<1)	/* Output Though Data Selector for TX1 pin */
-#define AK4114_OPS10		(1<<0)	/* Output Though Data Selector for TX1 pin */
+#define AK4114_OPS12		(1<<6)	/* Output Data Selector for TX1 pin */
+#define AK4114_OPS11		(1<<5)	/* Output Data Selector for TX1 pin */
+#define AK4114_OPS10		(1<<4)	/* Output Data Selector for TX1 pin */
 #define AK4114_TX0E		(1<<3)	/* TX0 Output Enable (1 = enable) */
-#define AK4114_OPS02		(1<<2)	/* Output Though Data Selector for TX0 pin */
-#define AK4114_OPS01		(1<<1)	/* Output Though Data Selector for TX0 pin */
-#define AK4114_OPS00		(1<<0)	/* Output Though Data Selector for TX0 pin */
+#define AK4114_OPS02		(1<<2)	/* Output Data Selector for TX0 pin */
+#define AK4114_OPS01		(1<<1)	/* Output Data Selector for TX0 pin */
+#define AK4114_OPS00		(1<<0)	/* Output Data Selector for TX0 pin */
 
 /* AK4114_REG_IO1 */
 #define AK4114_EFH1		(1<<7)	/* Interrupt 0 pin Hold */
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2009-09-17 16:30 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-15 22:39 [PATCH 1/7] ak4114 - fix errors in output selector bits pavel.hofman
2009-09-15 22:39 ` [PATCH 2/7] ak4620 support, codec regs listed in proc pavel.hofman
2009-09-15 22:39   ` [PATCH 3/7] ak4113 support pavel.hofman
2009-09-15 22:39     ` [PATCH 4/7] ice1724 - adding GPIO routines for mask and direction pavel.hofman
2009-09-15 22:39       ` [PATCH 5/7] ice1724 - pro-rate-locking makes sense only for internal clock mode pavel.hofman
2009-09-15 22:39         ` [PATCH 6/7] Support for multiple external clock types pavel.hofman
2009-09-15 22:39           ` [PATCH 7/7] Infrasonic Quartet support pavel.hofman
2009-09-16  6:07       ` [PATCH 4/7] ice1724 - adding GPIO routines for mask and direction Takashi Iwai
2009-09-16  7:15         ` Pavel Hofman
2009-09-16  7:48           ` Takashi Iwai
2009-09-16  8:10             ` Pavel Hofman
2009-09-16  8:27               ` Takashi Iwai
2009-09-16 20:15                 ` Pavel Hofman
2009-09-17 16:30                   ` Takashi Iwai
2009-09-16  6:03 ` [PATCH 1/7] ak4114 - fix errors in output selector bits Takashi Iwai
2009-09-16  7:00   ` Pavel Hofman
2009-09-16  7:45     ` Takashi Iwai
2009-09-16  7:48       ` Pavel Hofman
  -- strict thread matches above, loose matches on Subject: below --
2009-09-16 20:25 pavel.hofman
2009-09-16 20:25 ` [PATCH 2/7] ak4620 support, codec regs listed in proc pavel.hofman
2009-09-16 20:25   ` [PATCH 3/7] ak4113 support pavel.hofman
2009-09-16 20:25     ` [PATCH 4/7] ice1724 - adding GPIO routines for mask and direction pavel.hofman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.