All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Brindle <method@manicmethod.com>
To: selinux@tycho.nsa.gov, 515710-forwarded@bugs.debian.org,
	Russell Coker <russell@coker.com.au>
Subject: Re: policycoreutils: The error message on forkpty() failure is not clear or useful.
Date: Wed, 16 Sep 2009 17:15:22 -0400	[thread overview]
Message-ID: <4AB1556A.6000603@manicmethod.com> (raw)
In-Reply-To: <87ljlavbid.fsf@anzu.internal.golden-gryphon.com>



Manoj Srivastava wrote:
> Hi,
>
>          This has been reported against the Debian BTS.
>
>          The current error message when forkpty() fails is not clear or
>   useful. (Arguably, the erro message in the child branch cold also be
>   improved)  The following patch makes indicate what went wrong.  Probably
>   something better than this could be devised, but this is still a lot
>   better than the current code.
>
> --- open_init_pty.c.bak 2009-02-16 21:47:28.000000000 +1100
> +++ open_init_pty.c     2009-02-16 21:48:06.000000000 +1100
> @@ -153,7 +153,7 @@
>          }
>
>          if (child_pid<  0) {
> -               perror("Fork:");
> +               perror("forkpty():");
>                  fflush(stdout);
>                  fflush(stderr);
>                  exit(EX_OSERR);
>
>          manoj
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=515710


Merged in policycoreutils 2.0.74

git formatted patches preferred, or at least a diff from the bottom of 
the tree.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

      reply	other threads:[~2009-09-16 21:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-23 14:40 policycoreutils: The error message on forkpty() failure is not clear or useful Manoj Srivastava
2009-09-16 21:15 ` Joshua Brindle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB1556A.6000603@manicmethod.com \
    --to=method@manicmethod.com \
    --cc=515710-forwarded@bugs.debian.org \
    --cc=russell@coker.com.au \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.