policycoreutils: The error message on forkpty() failure is not clear or useful.

policycoreutils: The error message on forkpty() failure is not clear or useful.

[Manoj Srivastava]

Hi,

        This has been reported against the Debian BTS.

        The current error message when forkpty() fails is not clear or
 useful. (Arguably, the erro message in the child branch cold also be
 improved)  The following patch makes indicate what went wrong.  Probably
 something better than this could be devised, but this is still a lot
 better than the current code.

--- open_init_pty.c.bak 2009-02-16 21:47:28.000000000 +1100
+++ open_init_pty.c     2009-02-16 21:48:06.000000000 +1100
@@ -153,7 +153,7 @@
        }

        if (child_pid < 0) {
-               perror("Fork:");
+               perror("forkpty():");
                fflush(stdout);
                fflush(stderr);
                exit(EX_OSERR);

        manoj
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=515710
-- 
Manoj Srivastava <srivasta@acm.org> <http://www.golden-gryphon.com/>  
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: policycoreutils: The error message on forkpty() failure is not clear or useful.

[Joshua Brindle]

Manoj Srivastava wrote:
> Hi,
>
>          This has been reported against the Debian BTS.
>
>          The current error message when forkpty() fails is not clear or
>   useful. (Arguably, the erro message in the child branch cold also be
>   improved)  The following patch makes indicate what went wrong.  Probably
>   something better than this could be devised, but this is still a lot
>   better than the current code.
>
> --- open_init_pty.c.bak 2009-02-16 21:47:28.000000000 +1100
> +++ open_init_pty.c     2009-02-16 21:48:06.000000000 +1100
> @@ -153,7 +153,7 @@
>          }
>
>          if (child_pid<  0) {
> -               perror("Fork:");
> +               perror("forkpty():");
>                  fflush(stdout);
>                  fflush(stderr);
>                  exit(EX_OSERR);
>
>          manoj
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=515710


Merged in policycoreutils 2.0.74

git formatted patches preferred, or at least a diff from the bottom of 
the tree.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.