From: Mika Korhonen <ext-mika.2.korhonen@nokia.com>
To: "Hunter Adrian (Nokia-D/Helsinki)" <adrian.hunter@nokia.com>
Cc: "amul.saha@samsung.com" <amul.saha@samsung.com>,
"dedekind@infradead.org" <dedekind@infradead.org>,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 1/2] MTD: OneNAND: move erase method to a separate function
Date: Fri, 18 Sep 2009 07:45:56 +0300 [thread overview]
Message-ID: <4AB31084.7050904@nokia.com> (raw)
In-Reply-To: <4AB1132D.30705@nokia.com>
Hunter Adrian (Nokia-D/Helsinki) wrote:
> Korhonen Mika.2 (EXT-Ardites/Oulu) wrote:
>
>> Separate the actual execution of erase to a new function:
>> onenand_single_block_erase()
>>
>> Signed-off-by: Mika Korhonen <ext-mika.2.korhonen@nokia.com>
>> ---
>>
>
> The patch is fine but needs some minor style changes.
>
> Also the patch description should explain that this is in
> preparation for adding multiblock erase support.
>
Thanks for the feedback, I'll rework the patches and resend them in near
future.
br,
Mika
next prev parent reply other threads:[~2009-09-18 4:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 10:54 [PATCH 0/2] MTD: OneNAND: multiblock erase support Mika Korhonen
2009-09-03 10:54 ` [PATCH 1/2] MTD: OneNAND: move erase method to a separate function Mika Korhonen
2009-09-03 10:54 ` [PATCH 2/2] MTD: OneNAND: multiblock erase support Mika Korhonen
2009-09-16 16:32 ` Adrian Hunter
2009-09-18 5:03 ` Mika Korhonen
2009-09-18 5:38 ` Kyungmin Park
2009-09-18 8:04 ` Adrian Hunter
2009-09-18 8:33 ` Kyungmin Park
2009-09-16 16:32 ` [PATCH 1/2] MTD: OneNAND: move erase method to a separate function Adrian Hunter
2009-09-18 4:45 ` Mika Korhonen [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-06 8:55 [PATCH 0/2] Revised: MTD: OneNAND: multiblock erase support Mika Korhonen
2009-10-06 8:55 ` [PATCH 1/2] MTD: OneNAND: move erase method to a separate function Mika Korhonen
2009-10-06 9:13 ` Kyungmin Park
2009-10-06 9:18 ` Mika Korhonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB31084.7050904@nokia.com \
--to=ext-mika.2.korhonen@nokia.com \
--cc=adrian.hunter@nokia.com \
--cc=amul.saha@samsung.com \
--cc=dedekind@infradead.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.