Re: [PATCH 1/2] MTD: OneNAND: move erase method to a separate function

[Mika Korhonen <ext-mika.2.korhonen@nokia.com>]

ext Kyungmin Park wrote:
> On Tue, Oct 6, 2009 at 5:55 PM, Mika Korhonen
> <ext-mika.2.korhonen@nokia.com> wrote:
>   
>> Separate the actual execution of erase to a new function:
>> onenand_block_by_block_erase(). This is done in preparation for
>> the multiblock erase support.
>>
>> Signed-off-by: Mika Korhonen <ext-mika.2.korhonen@nokia.com>
>> ---
>>  drivers/mtd/onenand/onenand_base.c |  143 +++++++++++++++++++++---------------
>>  1 files changed, 84 insertions(+), 59 deletions(-)
>>     
[...]
>>        /* Do call back function */
>>        if (!ret)
>> +               instr->state = MTD_ERASE_DONE;
>>                mtd_erase_callback(instr);
>>     
>
> Are you missing curly braces { } here?
>
> Thank you
> Kyungmin Park
>   
Yes, I am. Thanks!

br
Mika