From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: Jens Axboe <jens.axboe@oracle.com>, Alasdair G Kergon <agk@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Li Zefan <lizf@cn.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add a tracepoint for block request remapping
Date: Sat, 19 Sep 2009 02:05:50 +0900 [thread overview]
Message-ID: <4AB3BDEE.8090800@ce.jp.nec.com> (raw)
In-Reply-To: <20090918104539.GX23126@kernel.dk>
Hi Jens, Alasdair,
Jens Axboe wrote:
> On Fri, Sep 18 2009, Jun'ichi Nomura wrote:
>> Since 2.6.31 now has request-based device-mapper, it's useful to have
>> a tracepoint for request-remapping as well as bio-remapping.
>>
>> This patch adds a tracepoint for request-remapping, trace_block_rq_remap().
>> Existing trace_block_remap() is left unchanged but it might be better to
>> rename it to trace_block_bio_remap().
>
> This looks good, we should definitely have a remap trace at that level
> too. Apart from that, nothing further to add than acking the observation
> that you need to make the ->device_to part of the trace endian clean.
>
> If you resend with that and just send the core bit (the dm part should
> go through the dm branch), then I'll include it for 2.6.32.
I resent a revised patchset but I'm afraid they might be confusing
as the other patchset for max_sectors/queue_limits were also sent
in parallel and I didn't make them look like a thread.
For your reference, these are the revised patchset for tracing
request-remap:
[PATCH 1/3] block: Add a tracepoint for block request remapping
https://www.redhat.com/archives/dm-devel/2009-September/msg00201.html
[PATCH 2/3] block: Rename trace_block_remap to trace_block_bio_remap
https://www.redhat.com/archives/dm-devel/2009-September/msg00202.html
[PATCH 3/3] dm: Add a remapping trace to request-based dm
https://www.redhat.com/archives/dm-devel/2009-September/msg00204.html
The 3rd patch for dm depends on the 1st.
--
Jun'ichi Nomura, NEC Corporation
WARNING: multiple messages have this Message-ID (diff)
From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: Jens Axboe <jens.axboe@oracle.com>, Alasdair G Kergon <agk@redhat.com>
Cc: linux-kernel@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>,
Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [PATCH] Add a tracepoint for block request remapping
Date: Sat, 19 Sep 2009 02:05:50 +0900 [thread overview]
Message-ID: <4AB3BDEE.8090800@ce.jp.nec.com> (raw)
In-Reply-To: <20090918104539.GX23126@kernel.dk>
Hi Jens, Alasdair,
Jens Axboe wrote:
> On Fri, Sep 18 2009, Jun'ichi Nomura wrote:
>> Since 2.6.31 now has request-based device-mapper, it's useful to have
>> a tracepoint for request-remapping as well as bio-remapping.
>>
>> This patch adds a tracepoint for request-remapping, trace_block_rq_remap().
>> Existing trace_block_remap() is left unchanged but it might be better to
>> rename it to trace_block_bio_remap().
>
> This looks good, we should definitely have a remap trace at that level
> too. Apart from that, nothing further to add than acking the observation
> that you need to make the ->device_to part of the trace endian clean.
>
> If you resend with that and just send the core bit (the dm part should
> go through the dm branch), then I'll include it for 2.6.32.
I resent a revised patchset but I'm afraid they might be confusing
as the other patchset for max_sectors/queue_limits were also sent
in parallel and I didn't make them look like a thread.
For your reference, these are the revised patchset for tracing
request-remap:
[PATCH 1/3] block: Add a tracepoint for block request remapping
https://www.redhat.com/archives/dm-devel/2009-September/msg00201.html
[PATCH 2/3] block: Rename trace_block_remap to trace_block_bio_remap
https://www.redhat.com/archives/dm-devel/2009-September/msg00202.html
[PATCH 3/3] dm: Add a remapping trace to request-based dm
https://www.redhat.com/archives/dm-devel/2009-September/msg00204.html
The 3rd patch for dm depends on the 1st.
--
Jun'ichi Nomura, NEC Corporation
next prev parent reply other threads:[~2009-09-18 17:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 1:42 [PATCH] Add a tracepoint for block request remapping Jun'ichi Nomura
2009-09-18 2:02 ` KOSAKI Motohiro
2009-09-18 5:57 ` Li Zefan
2009-09-18 5:57 ` Li Zefan
2009-09-18 14:34 ` Jun'ichi Nomura
2009-09-18 14:34 ` Jun'ichi Nomura
2009-09-18 10:45 ` Jens Axboe
2009-09-18 10:45 ` Jens Axboe
2009-09-18 17:05 ` Jun'ichi Nomura [this message]
2009-09-18 17:05 ` Jun'ichi Nomura
-- strict thread matches above, loose matches on Subject: below --
2009-09-21 16:25 Jun'ichi Nomura
2009-09-21 16:25 ` Jun'ichi Nomura
2009-09-21 19:11 ` Jens Axboe
2009-09-21 19:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB3BDEE.8090800@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.