* [patch] x86: fix cpumask_of_pcibus() to handle nid of -1
@ 2009-09-22 5:27 Suresh Siddha
2009-09-22 17:06 ` Yinghai Lu
2009-09-22 17:16 ` David Rientjes
0 siblings, 2 replies; 3+ messages in thread
From: Suresh Siddha @ 2009-09-22 5:27 UTC (permalink / raw)
To: tglx@linutronix.de, hpa@zytor.com, mingo@elte.hu
Cc: jbarnes, yinghai@kernel.org, linux-kernel@vger.kernel.org
On my two socket NHM-EP system, with CONFIG_DEBUG_PER_CPU_MAPS=y I see:
cpumask_of_node(-1): no node_to_cpumask_map!
Pid: 5635, comm: irqbalance Not tainted 2.6.31-07068-g43c1266-dirty #145
Call Trace:
[<ffffffff81031033>] cpumask_of_node+0x4f/0x58
[<ffffffff811b5a8c>] local_cpus_show+0x1f/0x48
[<ffffffff812c3c65>] dev_attr_show+0x20/0x44
[<ffffffff810fcade>] sysfs_read_file+0xb2/0x131
[<ffffffff810b2702>] vfs_read+0xab/0x147
[<ffffffff810b2862>] sys_read+0x47/0x6f
[<ffffffff8100af6b>] system_call_fastpath+0x16/0x1b
Fix x86 version of cpumask_of_pcibus() to handle node id of "-1"
(default value indicating that I/O isn't tied to any particular node).
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---
diff --git a/arch/x86/include/asm/pci.h b/arch/x86/include/asm/pci.h
index f76a162..b101e8c 100644
--- a/arch/x86/include/asm/pci.h
+++ b/arch/x86/include/asm/pci.h
@@ -143,7 +143,9 @@ static inline int __pcibus_to_node(const struct pci_bus *bus)
static inline const struct cpumask *
cpumask_of_pcibus(const struct pci_bus *bus)
{
- return cpumask_of_node(__pcibus_to_node(bus));
+ int node = __pcibus_to_node(bus);
+
+ return (node == -1) ? cpu_all_mask : cpumask_of_node(node);
}
#endif
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] x86: fix cpumask_of_pcibus() to handle nid of -1
2009-09-22 5:27 [patch] x86: fix cpumask_of_pcibus() to handle nid of -1 Suresh Siddha
@ 2009-09-22 17:06 ` Yinghai Lu
2009-09-22 17:16 ` David Rientjes
1 sibling, 0 replies; 3+ messages in thread
From: Yinghai Lu @ 2009-09-22 17:06 UTC (permalink / raw)
To: Suresh Siddha
Cc: tglx@linutronix.de, hpa@zytor.com, mingo@elte.hu, jbarnes,
linux-kernel@vger.kernel.org, David Rientjes, Linus Torvalds
Suresh Siddha wrote:
> On my two socket NHM-EP system, with CONFIG_DEBUG_PER_CPU_MAPS=y I see:
>
> cpumask_of_node(-1): no node_to_cpumask_map!
> Pid: 5635, comm: irqbalance Not tainted 2.6.31-07068-g43c1266-dirty #145
> Call Trace:
> [<ffffffff81031033>] cpumask_of_node+0x4f/0x58
> [<ffffffff811b5a8c>] local_cpus_show+0x1f/0x48
> [<ffffffff812c3c65>] dev_attr_show+0x20/0x44
> [<ffffffff810fcade>] sysfs_read_file+0xb2/0x131
> [<ffffffff810b2702>] vfs_read+0xab/0x147
> [<ffffffff810b2862>] sys_read+0x47/0x6f
> [<ffffffff8100af6b>] system_call_fastpath+0x16/0x1b
>
> Fix x86 version of cpumask_of_pcibus() to handle node id of "-1"
> (default value indicating that I/O isn't tied to any particular node).
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
> ---
>
> diff --git a/arch/x86/include/asm/pci.h b/arch/x86/include/asm/pci.h
> index f76a162..b101e8c 100644
> --- a/arch/x86/include/asm/pci.h
> +++ b/arch/x86/include/asm/pci.h
> @@ -143,7 +143,9 @@ static inline int __pcibus_to_node(const struct pci_bus *bus)
> static inline const struct cpumask *
> cpumask_of_pcibus(const struct pci_bus *bus)
> {
> - return cpumask_of_node(__pcibus_to_node(bus));
> + int node = __pcibus_to_node(bus);
> +
> + return (node == -1) ? cpu_all_mask : cpumask_of_node(node);
> }
> #endif
>
>
cpu_all_mask or cpu_online_mask?
YH
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] x86: fix cpumask_of_pcibus() to handle nid of -1
2009-09-22 5:27 [patch] x86: fix cpumask_of_pcibus() to handle nid of -1 Suresh Siddha
2009-09-22 17:06 ` Yinghai Lu
@ 2009-09-22 17:16 ` David Rientjes
1 sibling, 0 replies; 3+ messages in thread
From: David Rientjes @ 2009-09-22 17:16 UTC (permalink / raw)
To: Suresh Siddha
Cc: tglx@linutronix.de, hpa@zytor.com, mingo@elte.hu, jbarnes,
yinghai@kernel.org, linux-kernel@vger.kernel.org
On Mon, 21 Sep 2009, Suresh Siddha wrote:
> On my two socket NHM-EP system, with CONFIG_DEBUG_PER_CPU_MAPS=y I see:
>
> cpumask_of_node(-1): no node_to_cpumask_map!
> Pid: 5635, comm: irqbalance Not tainted 2.6.31-07068-g43c1266-dirty #145
> Call Trace:
> [<ffffffff81031033>] cpumask_of_node+0x4f/0x58
> [<ffffffff811b5a8c>] local_cpus_show+0x1f/0x48
> [<ffffffff812c3c65>] dev_attr_show+0x20/0x44
> [<ffffffff810fcade>] sysfs_read_file+0xb2/0x131
> [<ffffffff810b2702>] vfs_read+0xab/0x147
> [<ffffffff810b2862>] sys_read+0x47/0x6f
> [<ffffffff8100af6b>] system_call_fastpath+0x16/0x1b
>
> Fix x86 version of cpumask_of_pcibus() to handle node id of "-1"
> (default value indicating that I/O isn't tied to any particular node).
>
This is already fixed in -mm with
x86-default-pcibus-cpumask-to-all-cpus-if-it-lacks-affinity.patch and is
awaiting inclusion via Jesse Barnes' tree.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-22 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-22 5:27 [patch] x86: fix cpumask_of_pcibus() to handle nid of -1 Suresh Siddha
2009-09-22 17:06 ` Yinghai Lu
2009-09-22 17:16 ` David Rientjes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.