All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] ckptinfo.py: revert commit	8f99ace6513f958d572ef690d7af111991124f5c
Date: Thu, 24 Sep 2009 01:44:48 -0400	[thread overview]
Message-ID: <4ABB0750.9090707@librato.com> (raw)
In-Reply-To: <20090923215343.GB6876-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>



Matt Helsley wrote:
> On Tue, Sep 22, 2009 at 08:16:50PM -0400, Oren Laadan wrote:
>> Said commit "slightly" broke 'ckptinfo -ve', causing it to produce
>> only "--UNKNOWN--" objects.
>>
>> Signed-off-by: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
> 
> This one's my fault. In case you haven't already applied the reverted patch...
> I've got an alternate solution rolled in with my "extract kernel
> headers" branch which I should be able to post after I get the epoll
> patches posted.
> 
> Acked-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

It's in ckpt-v18. Improvements always welcome :)

Oren.

> 
>> ---
>>  ckptinfo.py |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/ckptinfo.py b/ckptinfo.py
>> index add73cb..1c98569 100755
>> --- a/ckptinfo.py
>> +++ b/ckptinfo.py
>> @@ -42,7 +42,7 @@ char *%s_to_str(int type)
>>  	switch (type) {
>>  """ % type
>>      for key in list:
>> -        print "#ifdef CKPT_%s\n\tcase CKPT_%s: return \"%s\";\n#endif" % (key, key, key)
>> +        print "\tcase CKPT_%s: return \"%s\";\n" % (key, key)
>>
>>      print """
>>  	}
>> -- 
>> 1.6.0.4
>>
>> _______________________________________________
>> Containers mailing list
>> Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
>> https://lists.linux-foundation.org/mailman/listinfo/containers

      parent reply	other threads:[~2009-09-24  5:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23  0:16 [PATCH] ckptinfo.py: revert commit 8f99ace6513f958d572ef690d7af111991124f5c Oren Laadan
     [not found] ` <1253665010-3472-1-git-send-email-orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-23 21:53   ` Matt Helsley
     [not found]     ` <20090923215343.GB6876-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-09-24  5:44       ` Oren Laadan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABB0750.9090707@librato.com \
    --to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.