All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ckptinfo.py: revert commit 8f99ace6513f958d572ef690d7af111991124f5c
@ 2009-09-23  0:16 Oren Laadan
       [not found] ` <1253665010-3472-1-git-send-email-orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Oren Laadan @ 2009-09-23  0:16 UTC (permalink / raw)
  To: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA

Said commit "slightly" broke 'ckptinfo -ve', causing it to produce
only "--UNKNOWN--" objects.

Signed-off-by: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
---
 ckptinfo.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ckptinfo.py b/ckptinfo.py
index add73cb..1c98569 100755
--- a/ckptinfo.py
+++ b/ckptinfo.py
@@ -42,7 +42,7 @@ char *%s_to_str(int type)
 	switch (type) {
 """ % type
     for key in list:
-        print "#ifdef CKPT_%s\n\tcase CKPT_%s: return \"%s\";\n#endif" % (key, key, key)
+        print "\tcase CKPT_%s: return \"%s\";\n" % (key, key)
 
     print """
 	}
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ckptinfo.py: revert commit 8f99ace6513f958d572ef690d7af111991124f5c
       [not found] ` <1253665010-3472-1-git-send-email-orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
@ 2009-09-23 21:53   ` Matt Helsley
       [not found]     ` <20090923215343.GB6876-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Helsley @ 2009-09-23 21:53 UTC (permalink / raw)
  To: Oren Laadan; +Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA

On Tue, Sep 22, 2009 at 08:16:50PM -0400, Oren Laadan wrote:
> Said commit "slightly" broke 'ckptinfo -ve', causing it to produce
> only "--UNKNOWN--" objects.
> 
> Signed-off-by: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>

This one's my fault. In case you haven't already applied the reverted patch...
I've got an alternate solution rolled in with my "extract kernel
headers" branch which I should be able to post after I get the epoll
patches posted.

Acked-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

> ---
>  ckptinfo.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ckptinfo.py b/ckptinfo.py
> index add73cb..1c98569 100755
> --- a/ckptinfo.py
> +++ b/ckptinfo.py
> @@ -42,7 +42,7 @@ char *%s_to_str(int type)
>  	switch (type) {
>  """ % type
>      for key in list:
> -        print "#ifdef CKPT_%s\n\tcase CKPT_%s: return \"%s\";\n#endif" % (key, key, key)
> +        print "\tcase CKPT_%s: return \"%s\";\n" % (key, key)
> 
>      print """
>  	}
> -- 
> 1.6.0.4
> 
> _______________________________________________
> Containers mailing list
> Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> https://lists.linux-foundation.org/mailman/listinfo/containers

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ckptinfo.py: revert commit 8f99ace6513f958d572ef690d7af111991124f5c
       [not found]     ` <20090923215343.GB6876-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
@ 2009-09-24  5:44       ` Oren Laadan
  0 siblings, 0 replies; 3+ messages in thread
From: Oren Laadan @ 2009-09-24  5:44 UTC (permalink / raw)
  To: Matt Helsley; +Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA



Matt Helsley wrote:
> On Tue, Sep 22, 2009 at 08:16:50PM -0400, Oren Laadan wrote:
>> Said commit "slightly" broke 'ckptinfo -ve', causing it to produce
>> only "--UNKNOWN--" objects.
>>
>> Signed-off-by: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
> 
> This one's my fault. In case you haven't already applied the reverted patch...
> I've got an alternate solution rolled in with my "extract kernel
> headers" branch which I should be able to post after I get the epoll
> patches posted.
> 
> Acked-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

It's in ckpt-v18. Improvements always welcome :)

Oren.

> 
>> ---
>>  ckptinfo.py |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/ckptinfo.py b/ckptinfo.py
>> index add73cb..1c98569 100755
>> --- a/ckptinfo.py
>> +++ b/ckptinfo.py
>> @@ -42,7 +42,7 @@ char *%s_to_str(int type)
>>  	switch (type) {
>>  """ % type
>>      for key in list:
>> -        print "#ifdef CKPT_%s\n\tcase CKPT_%s: return \"%s\";\n#endif" % (key, key, key)
>> +        print "\tcase CKPT_%s: return \"%s\";\n" % (key, key)
>>
>>      print """
>>  	}
>> -- 
>> 1.6.0.4
>>
>> _______________________________________________
>> Containers mailing list
>> Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
>> https://lists.linux-foundation.org/mailman/listinfo/containers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-09-24  5:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-23  0:16 [PATCH] ckptinfo.py: revert commit 8f99ace6513f958d572ef690d7af111991124f5c Oren Laadan
     [not found] ` <1253665010-3472-1-git-send-email-orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-23 21:53   ` Matt Helsley
     [not found]     ` <20090923215343.GB6876-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-09-24  5:44       ` Oren Laadan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.