From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Joakim Tjernlund
<Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
Esben Haabendal
<eha-SIcX2qgNSybd/EuGEV170n9LOBIZ5rWg@public.gmane.org>
Subject: Re: [PATCH] i2c-mpc: Do not generate STOP after read.
Date: Fri, 25 Sep 2009 12:01:17 +0200 [thread overview]
Message-ID: <4ABC94ED.6070508@grandegger.com> (raw)
In-Reply-To: <1253620242-18461-1-git-send-email-Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
Joakim Tjernlund wrote:
> The driver always ends a read with a STOP condition which
> breaks subsequent I2C reads/writes in the same transaction as
> these expect to do a repeated START(ReSTART).
>
> This will also help I2C multimaster as the bus will not be released
> after the first read, but when the whole transaction ends.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
Tested-by: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
on a MPC8548 board with an up-to-date kernel. I did not realize any
problems.
Wolfgang.
WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg@grandegger.com>
To: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Cc: linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org,
Esben Haabendal <eha@doredevelopment.dk>
Subject: Re: [PATCH] i2c-mpc: Do not generate STOP after read.
Date: Fri, 25 Sep 2009 12:01:17 +0200 [thread overview]
Message-ID: <4ABC94ED.6070508@grandegger.com> (raw)
In-Reply-To: <1253620242-18461-1-git-send-email-Joakim.Tjernlund@transmode.se>
Joakim Tjernlund wrote:
> The driver always ends a read with a STOP condition which
> breaks subsequent I2C reads/writes in the same transaction as
> these expect to do a repeated START(ReSTART).
>
> This will also help I2C multimaster as the bus will not be released
> after the first read, but when the whole transaction ends.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Tested-by: Wolfgang Grandegger <wg@grandegger.com>
on a MPC8548 board with an up-to-date kernel. I did not realize any
problems.
Wolfgang.
next prev parent reply other threads:[~2009-09-25 10:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 11:50 [PATCH] i2c-mpc: Do not generate STOP after read Joakim Tjernlund
2009-09-22 11:50 ` Joakim Tjernlund
[not found] ` <1253620242-18461-1-git-send-email-Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
2009-09-25 10:01 ` Wolfgang Grandegger [this message]
2009-09-25 10:01 ` Wolfgang Grandegger
2009-09-27 22:26 ` Joakim Tjernlund
[not found] ` <OFDA26E787.32612566-ONC125763E.007AD2FD-C125763E.007B4FFC-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
2009-09-28 7:28 ` Jean Delvare
2009-09-28 7:28 ` Jean Delvare
[not found] ` <20090928092809.7272b6e6-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-09-28 7:30 ` Joakim Tjernlund
2009-09-28 7:30 ` Joakim Tjernlund
[not found] ` <OFC822309E.F9FB4F3C-ONC125763F.0029159C-C125763F.00293F85-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
2009-09-28 7:33 ` Peter Korsgaard
2009-09-28 7:33 ` Peter Korsgaard
2009-09-28 7:34 ` Jean Delvare
2009-09-28 7:34 ` Jean Delvare
[not found] ` <20090928093434.57157435-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-09-28 7:43 ` Joakim Tjernlund
2009-09-28 7:43 ` Joakim Tjernlund
-- strict thread matches above, loose matches on Subject: below --
2009-10-13 8:12 Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABC94ED.6070508@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public.gmane.org \
--cc=Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org \
--cc=eha-SIcX2qgNSybd/EuGEV170n9LOBIZ5rWg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.