Re: xtables-addons ACCOUNT - userspace

Re: xtables-addons ACCOUNT - userspace

[Jan Rafaj]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1930 bytes --]


Hello Vlado,

I'm glad you find it useful, like me.

I've originally submitted my ports of

   xt_ACCOUNT ( _including_ the userspace iptaccount tool )
   xt_pknock ( with improved functionality over ipt_pknock 0.5 )
   xt_stealth

for inclusion to xtables-addons (Xt-a) few weeks ago. So far Jan 
Engelhardt, its maintainer, has added just the kernel part of ACCOUNT
to Xt-a, perhaps due to lack of time and becouse he probably didnt want
to delay release of Xt-a 1.18 .

You may try to ask him about the current status of adding iptaccount
as well as the other modules I "ported" (I'm looking forward to this too).

>From what I know the troublesome part is that I didnt do the ports
in git, so he will need to pluck apart all my changes and stuff it
into git as separate commits. (Next time - if there will be such time
- I wont make this mistake again).

In the meantime, you may find the patch against Xt-a 1.17 containing
all the three above at:

     ftp://ftp.unob.cz/pub/linux/patches/xtables-addons/

, and each of these in a form of separate patches against Xt-a 1.17 here:

     http://www.spinics.net/lists/netfilter-devel/msg10340.html

Best regards,

Jan


On Wed, 23 Sep 2009, Vlado Držík wrote:

> Hello Jan,
>
> I've noticed that you are the one who is behind porting the ACCOUNT
> module to xtables-addons framework.
> I'd like to thank you for this work. It's great extension that will
> surely benefit from this work as less effort will be needed in future
> for maintaining compatibility.
> Kernel and iptables part is workig for me (at least I'm able to craete a
> rule in iptables) but I'm not able to read state from this module via
> iptaccount command line utility (seems that protocol changed or
> something like that) and compiling the library against this new
> infrastructure seems not to be so trivial for me.
>
> So I wanted to ask you if you already have this part working.
>
> Thanks,
> Vlado
>

Re: xtables-addons ACCOUNT - userspace

[Jan Engelhardt]

On Wednesday 2009-09-23 22:11, Jan Rafaj wrote:
>
> I'm glad you find it useful, like me.
>
> I've originally submitted my ports of [ACCOUNT, ...]
> for inclusion to xtables-addons (Xt-a) few weeks ago. So far Jan Engelhardt,
> its maintainer, has added just the kernel part of ACCOUNT
> to Xt-a, perhaps due to lack of time and becouse he probably didnt want
> to delay release of Xt-a 1.18 .
>
> You may try to ask him about the current status of adding iptaccount
> as well as the other modules I "ported" (I'm looking forward to this too).
> From what I know the troublesome part is that I didnt do the ports
> in git, so he will need to pluck apart all my changes and stuff it
> into git as separate commits. (Next time - if there will be such time
> - I wont make this mistake again).

The troublesome part was the extra GNUmakefile.in you proposed
adding. I spent the last days on getting Automake back and not
having to use too many own makefiles, because that would lead
to an update nightmare. (Now it's all nice.)

Please test the latest ACCOUNT-e37985b.

Re: xtables-addons ACCOUNT - userspace

[Vlado Držík]

Thanks for that!,
I was able to get also the userspace part working with snapshot from
ACCOUNT branch but I'm not able to compile whole xtables-addons from
this branch.

Compile was running on CentOS 5 (x86 and x86_64)

I've recieved following when trying compile:
make  all-recursive
make[1]: Entering directory `/usr/src/xtables-addons'
Making all in extensions
make[2]: Entering directory `/usr/src/xtables-addons/extensions'
if [ -n "/usr/src/linux-2.6.31" ]; then make -C /usr/src/linux-2.6.31 M=
modules; fi;
make[3]: Entering directory `/usr/src/linux-2.6.31'
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  SYMLINK include/asm -> include/asm-x86
  CALL    scripts/checksyscalls.sh
  Building modules, stage 2.
  MODPOST 452 modules
make[3]: Leaving directory `/usr/src/linux-2.6.31'
make -f ../Makefile.iptrules all;
make[3]: Entering directory `/usr/src/xtables-addons/extensions'
  CC     libxt_RAWDNAT.oo
In file included from libxt_RAWDNAT.c:17:
xt_RAWNAT.h:5: error: field ‘addr’ has incomplete type
make[3]: *** [libxt_RAWDNAT.oo] Error 1
make[3]: Leaving directory `/usr/src/xtables-addons/extensions'
make[2]: *** [user-all-local] Error 2
make[2]: Leaving directory `/usr/src/xtables-addons/extensions'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/xtables-addons'
make: *** [all] Error 2

Do you have any clue what can be possibly wrong?
Regards,
Vlado


Jan Engelhardt  wrote / napísal(a):
> On Wednesday 2009-09-23 22:11, Jan Rafaj wrote:
>> I'm glad you find it useful, like me.
>>
>> I've originally submitted my ports of [ACCOUNT, ...]
>> for inclusion to xtables-addons (Xt-a) few weeks ago. So far Jan Engelhardt,
>> its maintainer, has added just the kernel part of ACCOUNT
>> to Xt-a, perhaps due to lack of time and becouse he probably didnt want
>> to delay release of Xt-a 1.18 .
>>
>> You may try to ask him about the current status of adding iptaccount
>> as well as the other modules I "ported" (I'm looking forward to this too).
>> From what I know the troublesome part is that I didnt do the ports
>> in git, so he will need to pluck apart all my changes and stuff it
>> into git as separate commits. (Next time - if there will be such time
>> - I wont make this mistake again).
> 
> The troublesome part was the extra GNUmakefile.in you proposed
> adding. I spent the last days on getting Automake back and not
> having to use too many own makefiles, because that would lead
> to an update nightmare. (Now it's all nice.)
> 
> Please test the latest ACCOUNT-e37985b.
> 

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: xtables-addons ACCOUNT - userspace

[Jan Engelhardt]

On Thursday 2009-09-24 22:58, Vlado Držík wrote:

>Thanks for that!,
>I was able to get also the userspace part working with snapshot from
>ACCOUNT branch but I'm not able to compile whole xtables-addons from
>this branch.
>
>Compile was running on CentOS 5 (x86 and x86_64)
>
>I've recieved following when trying compile:
>  CC     libxt_RAWDNAT.oo
>In file included from libxt_RAWDNAT.c:17:
>xt_RAWNAT.h:5: error: field ‘addr’ has incomplete type
>
>Do you have any clue what can be possibly wrong?

I could imagine that, on systems with a /usr/include/linux older than 
2.6.25, you need to point it to the iptables source tree, which has a 
timely copy of linux/netfilter.h shipping said type; in other words, 
please try:

	./configure --with-xtables=/path/to/iptables.src
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: xtables-addons ACCOUNT - userspace

[Vlado Držík]

Thanks for pointer,
it works for me now on 2.6.31 and iptables 1.4.4

Regards,
Vlado
Jan Engelhardt  wrote / napísal(a):
> On Thursday 2009-09-24 22:58, Vlado Držík wrote:
> 
>> Thanks for that!,
>> I was able to get also the userspace part working with snapshot from
>> ACCOUNT branch but I'm not able to compile whole xtables-addons from
>> this branch.
>>
>> Compile was running on CentOS 5 (x86 and x86_64)
>>
>> I've recieved following when trying compile:
>>  CC     libxt_RAWDNAT.oo
>> In file included from libxt_RAWDNAT.c:17:
>> xt_RAWNAT.h:5: error: field ‘addr’ has incomplete type
>>
>> Do you have any clue what can be possibly wrong?
> 
> I could imagine that, on systems with a /usr/include/linux older than 
> 2.6.25, you need to point it to the iptables source tree, which has a 
> timely copy of linux/netfilter.h shipping said type; in other words, 
> please try:
> 
> 	./configure --with-xtables=/path/to/iptables.src
> 

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: xtables-addons ACCOUNT - userspace

[Jan Rafaj]

On Thu, 24 Sep 2009, Jan Engelhardt wrote:

> Please test the latest ACCOUNT-e37985b.

Done. It works fine here (linux 2.6.29.6, iptables 1.4.4).

Thanks,

Jan