* [U-Boot] AT91 pending patches
@ 2009-09-21 19:35 Eric Bénard
2009-09-21 23:07 ` Tom
2009-09-27 23:46 ` Tom
0 siblings, 2 replies; 5+ messages in thread
From: Eric Bénard @ 2009-09-21 19:35 UTC (permalink / raw)
To: u-boot
Hi Tom,
may you please comment on the following patches :
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/67400
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/65674
Many thanks
Eric
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] AT91 pending patches
2009-09-21 19:35 [U-Boot] AT91 pending patches Eric Bénard
@ 2009-09-21 23:07 ` Tom
2009-09-27 23:46 ` Tom
1 sibling, 0 replies; 5+ messages in thread
From: Tom @ 2009-09-21 23:07 UTC (permalink / raw)
To: u-boot
Eric B?nard wrote:
> Hi Tom,
>
> may you please comment on the following patches :
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/67400
[U-Boot] [PATCH] Add support for Eukrea CPU9260/CPU9G20 SBC
these boards are built around Atmel's AT91SAM9260/9G20 and have
up to 64MB of NOR flash, up to 128MB of SDRAM, up to 2GB of NAND
and include a 10/100 Ethernet PHY in RMII mode.
This looks like the first revision.
Only comments from Jean.
He liked it so that's an ack .
Some minor ws issues
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/65674
CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR
flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII
mode.
Lots of ws cleanup from v5 to v6.
checkpatch complaining about
checkpatch.pl cpuat91-v6.patch
WARNING: braces {} are not necessary for single statement blocks
#480: FILE: cpu/arm920t/at91rm9200/ks8721.c:222:
+ if (!(value & KS8721_AUTONEG_COMP)) {
+ return 0;
+ }
I will take care of this.
From history, lots of comments
I will do the merge and push these patches this weekend after running
the compiling the configurations. There will be some obvious
conflicts like your maintainer list of boards that I will just handle.
Tom
>
> Many thanks
> Eric
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] AT91 pending patches
2009-09-21 19:35 [U-Boot] AT91 pending patches Eric Bénard
2009-09-21 23:07 ` Tom
@ 2009-09-27 23:46 ` Tom
2009-10-09 9:28 ` [U-Boot] [PATCH 1/2] fix cpuat91 compile warning Eric Benard
1 sibling, 1 reply; 5+ messages in thread
From: Tom @ 2009-09-27 23:46 UTC (permalink / raw)
To: u-boot
Eric B?nard wrote:
> Hi Tom,
>
> may you please comment on the following patches :
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/67400
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/65674
>
> Many thanks
> Eric
Eric,
Your patches have been added to arm/next.
CPU9260 and CPU9G60 had this *.ERR in MAKEALL arm
nand_util.c:45:2: warning: #warning Please define
CONFIG_SYS_64BIT_VSPRINTF for correct output!
CPUAT91 had this *.ERR
eth.c:497:2: warning: #warning Ethernet driver is deprecated. Please
update to use CONFIG_NET_MULTI
main.c: In function 'abortboot':
main.c:122: warning: too few arguments for format
Please verify your changes are included and submit fixes for these
warning if appropriate.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/2] fix cpuat91 compile warning
2009-09-27 23:46 ` Tom
@ 2009-10-09 9:28 ` Eric Benard
2009-10-09 9:28 ` [U-Boot] [PATCH 2/2] fix CPU9260/CPU9G20 compile warnings Eric Benard
0 siblings, 1 reply; 5+ messages in thread
From: Eric Benard @ 2009-10-09 9:28 UTC (permalink / raw)
To: u-boot
main.c: In function 'abortboot':
main.c:122: warning: too few arguments for format
Signed-off-by: Eric Benard <eric@eukrea.com>
---
include/configs/cpuat91.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/cpuat91.h b/include/configs/cpuat91.h
index 0d3acf6..8746f70 100644
--- a/include/configs/cpuat91.h
+++ b/include/configs/cpuat91.h
@@ -189,8 +189,8 @@
#define CONFIG_SILENT_CONSOLE 1
#define CONFIG_AUTOBOOT_KEYED 1
-#define CONFIG_AUTOBOOT_PROMPT \
- "Press SPACE to abort autoboot in %d seconds\n"
+#define CONFIG_AUTOBOOT_PROMPT \
+ "Press SPACE to abort autoboot\n"
#define CONFIG_AUTOBOOT_STOP_STR " "
#define CONFIG_AUTOBOOT_DELAY_STR "d"
--
1.6.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-10-09 9:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-21 19:35 [U-Boot] AT91 pending patches Eric Bénard
2009-09-21 23:07 ` Tom
2009-09-27 23:46 ` Tom
2009-10-09 9:28 ` [U-Boot] [PATCH 1/2] fix cpuat91 compile warning Eric Benard
2009-10-09 9:28 ` [U-Boot] [PATCH 2/2] fix CPU9260/CPU9G20 compile warnings Eric Benard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.