* [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl722b.c
@ 2009-09-28 21:11 Bruce Jones
2009-10-02 22:11 ` Greg KH
2009-10-02 22:16 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Bruce Jones @ 2009-09-28 21:11 UTC (permalink / raw)
To: gregkh; +Cc: wfp5, devel, linux-kernel
Cleanup this file as per the coding style. Adding KERN_INFO to
the printks.
Signed-off-by: Bruce Jones <brucej@linux.com>
---
drivers/staging/comedi/drivers/acl7225b.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
index c3652ef..e6c6c87 100644
--- a/drivers/staging/comedi/drivers/acl7225b.c
+++ b/drivers/staging/comedi/drivers/acl7225b.c
@@ -94,7 +94,7 @@ static int acl7225b_attach(struct comedi_device *dev,
iobase = it->options[0];
iorange = this_board->io_range;
- printk("comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
+ printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
this_board->name, iobase);
if (!request_region(iobase, iorange, "acl7225b")) {
printk("I/O port conflict\n");
@@ -137,14 +137,14 @@ static int acl7225b_attach(struct comedi_device *dev,
s->range_table = &range_digital;
s->private = (void *)ACL7225_DI_LO;
- printk("\n");
+ printk(KERN_INFO "\n");
return 0;
}
static int acl7225b_detach(struct comedi_device *dev)
{
- printk("comedi%d: acl7225b: remove\n", dev->minor);
+ printk(KERN_INFO "comedi%d: acl7225b: remove\n", dev->minor);
if (dev->iobase)
release_region(dev->iobase, this_board->io_range);
--
1.6.5.rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl722b.c
2009-09-28 21:11 [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl722b.c Bruce Jones
@ 2009-10-02 22:11 ` Greg KH
2009-10-02 22:16 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2009-10-02 22:11 UTC (permalink / raw)
To: Bruce Jones; +Cc: gregkh, devel, wfp5, linux-kernel
On Mon, Sep 28, 2009 at 02:11:33PM -0700, Bruce Jones wrote:
> Cleanup this file as per the coding style. Adding KERN_INFO to
> the printks.
>
> Signed-off-by: Bruce Jones <brucej@linux.com>
> ---
> drivers/staging/comedi/drivers/acl7225b.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
> index c3652ef..e6c6c87 100644
> --- a/drivers/staging/comedi/drivers/acl7225b.c
> +++ b/drivers/staging/comedi/drivers/acl7225b.c
> @@ -94,7 +94,7 @@ static int acl7225b_attach(struct comedi_device *dev,
>
> iobase = it->options[0];
> iorange = this_board->io_range;
> - printk("comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
> + printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
> this_board->name, iobase);
> if (!request_region(iobase, iorange, "acl7225b")) {
> printk("I/O port conflict\n");
> @@ -137,14 +137,14 @@ static int acl7225b_attach(struct comedi_device *dev,
> s->range_table = &range_digital;
> s->private = (void *)ACL7225_DI_LO;
>
> - printk("\n");
> + printk(KERN_INFO "\n");
This one change isn't needed, the \n has to be sent as the earlier
printk didn't terminate the line. I applied it without this change, so
no worries.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl722b.c
2009-09-28 21:11 [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl722b.c Bruce Jones
2009-10-02 22:11 ` Greg KH
@ 2009-10-02 22:16 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2009-10-02 22:16 UTC (permalink / raw)
To: Bruce Jones; +Cc: gregkh, devel, wfp5, linux-kernel
On Mon, Sep 28, 2009 at 02:11:33PM -0700, Bruce Jones wrote:
> Cleanup this file as per the coding style. Adding KERN_INFO to
> the printks.
>
> Signed-off-by: Bruce Jones <brucej@linux.com>
> ---
> drivers/staging/comedi/drivers/acl7225b.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
> index c3652ef..e6c6c87 100644
> --- a/drivers/staging/comedi/drivers/acl7225b.c
> +++ b/drivers/staging/comedi/drivers/acl7225b.c
> @@ -94,7 +94,7 @@ static int acl7225b_attach(struct comedi_device *dev,
>
> iobase = it->options[0];
> iorange = this_board->io_range;
> - printk("comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
> + printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
> this_board->name, iobase);
> if (!request_region(iobase, iorange, "acl7225b")) {
> printk("I/O port conflict\n");
> @@ -137,14 +137,14 @@ static int acl7225b_attach(struct comedi_device *dev,
> s->range_table = &range_digital;
> s->private = (void *)ACL7225_DI_LO;
>
> - printk("\n");
> + printk(KERN_INFO "\n");
Oh nevermind, I took your later patch, sorry for the confusion.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-02 23:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-28 21:11 [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl722b.c Bruce Jones
2009-10-02 22:11 ` Greg KH
2009-10-02 22:16 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.