* [U-Boot] V2 of OMAP3 USB device Support
[not found] <931944283939480137@unknownmsgid>
@ 2009-09-29 18:50 ` Remy Bohmer
2009-09-29 18:59 ` Tom
0 siblings, 1 reply; 6+ messages in thread
From: Remy Bohmer @ 2009-09-29 18:50 UTC (permalink / raw)
To: u-boot
Hi,
2009/9/28 <y@windriver.com>:
What is the difference between sender 'y' and 'Tom Rix'?
I guess I can safely ignore the 'y' sender...?
Remy
>
> The technical change is better handling of address setting on the
> usb handshaking setup phase.
>
> Other changes from Jean's comments
>
> 2/8 USB add macros for debugging usb device setup.
>
> static inline function replacing debug macros
>
> 3/8 TWL4030 Add usb PHY support
>
> add empty lines between variables and statements
> other empty lines added for readablity
>
> 4/8 OMAP3 Add usb device support
>
> 80+ char lines reduced
> Used MUSB_FLAGS_PRINT macro suggestion
> lowercased function names
> multi-lined ep0_state_enum
> Used suggestion on udelay to 1000 * 1000
> add empty lines between variables and statements
> inverted check of ep0_urb->device_request.wLength
> other empty lines added for readablity
>
> 5/8 OMAP3 zoom1 Add usbtty configuration
>
> This was ack-ed by Jean
>
> 6/8 OMAP3 beagle Add usbtty configuration
>
> This was ack-ed by Jean
>
> 8/8 OMAP3 zoom2 Use usbtty if the debug board
>
> cleanup using usbtty_* functions or their stubs without #define's
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] V2 of OMAP3 USB device Support
@ 2009-09-28 16:37 Tom Rix
2009-10-11 16:25 ` Paulraj, Sandeep
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rix @ 2009-09-28 16:37 UTC (permalink / raw)
To: u-boot
The technical change is better handling of address setting on the
usb handshaking setup phase.
Other changes from Jean's comments
2/8 USB add macros for debugging usb device setup.
static inline function replacing debug macros
3/8 TWL4030 Add usb PHY support
add empty lines between variables and statements
other empty lines added for readablity
4/8 OMAP3 Add usb device support
80+ char lines reduced
Used MUSB_FLAGS_PRINT macro suggestion
lowercased function names
multi-lined ep0_state_enum
Used suggestion on udelay to 1000 * 1000
add empty lines between variables and statements
inverted check of ep0_urb->device_request.wLength
other empty lines added for readablity
5/8 OMAP3 zoom1 Add usbtty configuration
This was ack-ed by Jean
6/8 OMAP3 beagle Add usbtty configuration
This was ack-ed by Jean
8/8 OMAP3 zoom2 Use usbtty if the debug board
cleanup using usbtty_* functions or their stubs without #define's
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] V2 of OMAP3 USB device Support
2009-09-28 16:37 Tom Rix
@ 2009-10-11 16:25 ` Paulraj, Sandeep
2009-10-11 16:52 ` Tom Rix
0 siblings, 1 reply; 6+ messages in thread
From: Paulraj, Sandeep @ 2009-10-11 16:25 UTC (permalink / raw)
To: u-boot
>
>
> The technical change is better handling of address setting on the
> usb handshaking setup phase.
>
> Other changes from Jean's comments
>
> 2/8 USB add macros for debugging usb device setup.
>
> static inline function replacing debug macros
>
> 3/8 TWL4030 Add usb PHY support
>
> add empty lines between variables and statements
> other empty lines added for readablity
>
> 4/8 OMAP3 Add usb device support
>
> 80+ char lines reduced
> Used MUSB_FLAGS_PRINT macro suggestion
> lowercased function names
> multi-lined ep0_state_enum
> Used suggestion on udelay to 1000 * 1000
> add empty lines between variables and statements
> inverted check of ep0_urb->device_request.wLength
> other empty lines added for readablity
>
> 5/8 OMAP3 zoom1 Add usbtty configuration
>
> This was ack-ed by Jean
>
> 6/8 OMAP3 beagle Add usbtty configuration
>
> This was ack-ed by Jean
>
> 8/8 OMAP3 zoom2 Use usbtty if the debug board
>
> cleanup using usbtty_* functions or their stubs without #define's
Tom,
Some of these clearly say that they were Ack-ed by Jean.
Did he not push them?
How do we want to proceed with this set of patches?
Thanks,
Sandeep
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] V2 of OMAP3 USB device Support
2009-10-11 16:25 ` Paulraj, Sandeep
@ 2009-10-11 16:52 ` Tom Rix
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rix @ 2009-10-11 16:52 UTC (permalink / raw)
To: u-boot
Paulraj, Sandeep wrote:
>>
>> The technical change is better handling of address setting on the
>> usb handshaking setup phase.
>>
>> Other changes from Jean's comments
>>
>> 2/8 USB add macros for debugging usb device setup.
>>
>> static inline function replacing debug macros
>>
>> 3/8 TWL4030 Add usb PHY support
>>
>> add empty lines between variables and statements
>> other empty lines added for readablity
>>
>> 4/8 OMAP3 Add usb device support
>>
>> 80+ char lines reduced
>> Used MUSB_FLAGS_PRINT macro suggestion
>> lowercased function names
>> multi-lined ep0_state_enum
>> Used suggestion on udelay to 1000 * 1000
>> add empty lines between variables and statements
>> inverted check of ep0_urb->device_request.wLength
>> other empty lines added for readablity
>>
>> 5/8 OMAP3 zoom1 Add usbtty configuration
>>
>> This was ack-ed by Jean
>>
>> 6/8 OMAP3 beagle Add usbtty configuration
>>
>> This was ack-ed by Jean
>>
>> 8/8 OMAP3 zoom2 Use usbtty if the debug board
>>
>> cleanup using usbtty_* functions or their stubs without #define's
>
> Tom,
>
> Some of these clearly say that they were Ack-ed by Jean.
>
> Did he not push them?
>
Because there were issues with other patches in the patch-set,
these were not pushed.
> How do we want to proceed with this set of patches?
>
There is some changes that may effect davinci.
You should verify that davici targets behave the same.
I believe someone on beagle.org has verified that at least
the usb console works for beagle. There was an issue with
kermit over usbtty that was reported. I do not consider
this to be a blocking issue. More verification that
the patch works for other poeople would be helpful.
The top usb patch is general and should really be reviewed
as a USB change.
These patches are the basis for my current usb development
to get the cdc gadget support from the usb topic branch into
the mainline.
So if changes are needed, it would be good to find out about
them sooner rather than later when I have more code dependent
on them.
Tom
> Thanks,
> Sandeep
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] V2 of OMAP3 USB device Support
@ 2009-09-28 16:34 y at windriver.com
0 siblings, 0 replies; 6+ messages in thread
From: y at windriver.com @ 2009-09-28 16:34 UTC (permalink / raw)
To: u-boot
The technical change is better handling of address setting on the
usb handshaking setup phase.
Other changes from Jean's comments
2/8 USB add macros for debugging usb device setup.
static inline function replacing debug macros
3/8 TWL4030 Add usb PHY support
add empty lines between variables and statements
other empty lines added for readablity
4/8 OMAP3 Add usb device support
80+ char lines reduced
Used MUSB_FLAGS_PRINT macro suggestion
lowercased function names
multi-lined ep0_state_enum
Used suggestion on udelay to 1000 * 1000
add empty lines between variables and statements
inverted check of ep0_urb->device_request.wLength
other empty lines added for readablity
5/8 OMAP3 zoom1 Add usbtty configuration
This was ack-ed by Jean
6/8 OMAP3 beagle Add usbtty configuration
This was ack-ed by Jean
8/8 OMAP3 zoom2 Use usbtty if the debug board
cleanup using usbtty_* functions or their stubs without #define's
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-10-11 16:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <931944283939480137@unknownmsgid>
2009-09-29 18:50 ` [U-Boot] V2 of OMAP3 USB device Support Remy Bohmer
2009-09-29 18:59 ` Tom
2009-09-28 16:37 Tom Rix
2009-10-11 16:25 ` Paulraj, Sandeep
2009-10-11 16:52 ` Tom Rix
-- strict thread matches above, loose matches on Subject: below --
2009-09-28 16:34 y at windriver.com
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.