[PATCH] acerhdf: Limit modalias matching to supported boards

[PATCH] acerhdf: Limit modalias matching to supported boards

[Stefan Bader]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

We got reports of acerhdf issuing warnings on Acer laptops other than Aspire 
Ones. Looking at the dmi match this sounds a bit to generic. IOW the module 
gets loaded on any Acer laptop. After the following patch the module gets still 
loaded on my Aspire One but not on the reported other laptop.
The same change might be helpful for the other two dmi matches, but I had no 
way of testing.

-Stefan


[-- Attachment #2: 0001-acerhdf-Limit-modalias-matching-to-supporte.patch --]
[-- Type: text/x-diff, Size: 1358 bytes --]

>From 389f61f7e66ce615dc6418cb856e167edaa74b42 Mon Sep 17 00:00:00 2001
From: Stefan Bader <stefan.bader@canonical.com>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to supported boards

BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958

The module alias currently matches any Acer computer but when loaded the
BIOS checks will only succeed on Aspire One models. This causes a invalid
BIOS warning for all other models (seen on Aspire 4810T).
This is not fatal but worries users that see this message. Limiting the
moule alias to models starting with AOA. Probably the same change should be
made for the two other entries.

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 drivers/platform/x86/acerhdf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index aa298d6..763f233 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter Feuerer");
 MODULE_DESCRIPTION("Aspire One temperature and fan driver");
-MODULE_ALIAS("dmi:*:*Acer*:*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
 MODULE_ALIAS("dmi:*:*Gateway*:*:");
 MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
 
-- 
1.5.4.5

Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Borislav Petkov]

On Wed, Sep 30, 2009 at 02:13:55PM +0200, Stefan Bader wrote:
> We got reports of acerhdf issuing warnings on Acer laptops other
> than Aspire Ones. Looking at the dmi match this sounds a bit to
> generic. IOW the module gets loaded on any Acer laptop. After the
> following patch the module gets still loaded on my Aspire One but
> not on the reported other laptop.
> The same change might be helpful for the other two dmi matches, but
> I had no way of testing.

Yeah, we might need someone with such a machine to give us
/sys/class/dmi/id/modalias content. Peter, do you have any users with
such machines?

> From 389f61f7e66ce615dc6418cb856e167edaa74b42 Mon Sep 17 00:00:00 2001
> From: Stefan Bader <stefan.bader@canonical.com>
> Date: Mon, 28 Sep 2009 17:11:29 +0000
> Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to supported boards
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958
> 
> The module alias currently matches any Acer computer but when loaded the
> BIOS checks will only succeed on Aspire One models. This causes a invalid
> BIOS warning for all other models (seen on Aspire 4810T).
> This is not fatal but worries users that see this message. Limiting the
> moule alias to models starting with AOA. Probably the same change should be
> made for the two other entries.
> 
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

Acked-by: Borislav Petkov <petkovbb@gmail.com>

> ---
>  drivers/platform/x86/acerhdf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index aa298d6..763f233 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Peter Feuerer");
>  MODULE_DESCRIPTION("Aspire One temperature and fan driver");
> -MODULE_ALIAS("dmi:*:*Acer*:*:");
> +MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
>  MODULE_ALIAS("dmi:*:*Gateway*:*:");
>  MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
>  
> -- 
> 1.5.4.5
> 


-- 
Regards/Gruss,
    Boris.

Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Peter Feuerer]

Borislav Petkov writes:

> On Wed, Sep 30, 2009 at 02:13:55PM +0200, Stefan Bader wrote:
>> We got reports of acerhdf issuing warnings on Acer laptops other
>> than Aspire Ones. Looking at the dmi match this sounds a bit to
>> generic. IOW the module gets loaded on any Acer laptop. After the
>> following patch the module gets still loaded on my Aspire One but
>> not on the reported other laptop.
>> The same change might be helpful for the other two dmi matches, but
>> I had no way of testing.
> 
> Yeah, we might need someone with such a machine to give us
> /sys/class/dmi/id/modalias content. Peter, do you have any users with
> such machines?

I search my acerhdf-inbox for the people who sent me the BIOS versions, 
maybe they still have the netbook and can me send the modalias content. I'll 
hopefully find some time upcoming weekend.

But, can't we simply assume, following dmi lines?

MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");

We have exactly those constellations within the BIOS settings table. If I 
interpret the modalias line correctly, "pnAOA110" means "Product Name 
AOA110" and that's what we have already in the BIOS settings table. So I 
think we do already have all information we need to create a complete patch 
for the problem, or am I wrong?

> 
>> From 389f61f7e66ce615dc6418cb856e167edaa74b42 Mon Sep 17 00:00:00 2001
>> From: Stefan Bader <stefan.bader@canonical.com>
>> Date: Mon, 28 Sep 2009 17:11:29 +0000
>> Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to supported boards
>> 
>> BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958
>> 
>> The module alias currently matches any Acer computer but when loaded the
>> BIOS checks will only succeed on Aspire One models. This causes a invalid
>> BIOS warning for all other models (seen on Aspire 4810T).
>> This is not fatal but worries users that see this message. Limiting the
>> moule alias to models starting with AOA. Probably the same change should be
>> made for the two other entries.
>> 
>> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> 
> Acked-by: Borislav Petkov <petkovbb@gmail.com>
> 
>> ---
>>  drivers/platform/x86/acerhdf.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
>> index aa298d6..763f233 100644
>> --- a/drivers/platform/x86/acerhdf.c
>> +++ b/drivers/platform/x86/acerhdf.c
>> @@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)
>>  MODULE_LICENSE("GPL");
>>  MODULE_AUTHOR("Peter Feuerer");
>>  MODULE_DESCRIPTION("Aspire One temperature and fan driver");
>> -MODULE_ALIAS("dmi:*:*Acer*:*:");
>> +MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
>>  MODULE_ALIAS("dmi:*:*Gateway*:*:");
>>  MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
>>  
>> -- 
>> 1.5.4.5

kind regards,
--peter

Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Stefan Bader]

[-- Attachment #1: Type: text/plain, Size: 3309 bytes --]

Peter Feuerer wrote:
> Borislav Petkov writes:
> 
>> On Wed, Sep 30, 2009 at 02:13:55PM +0200, Stefan Bader wrote:
>>> We got reports of acerhdf issuing warnings on Acer laptops other
>>> than Aspire Ones. Looking at the dmi match this sounds a bit to
>>> generic. IOW the module gets loaded on any Acer laptop. After the
>>> following patch the module gets still loaded on my Aspire One but
>>> not on the reported other laptop.
>>> The same change might be helpful for the other two dmi matches, but
>>> I had no way of testing.
>>
>> Yeah, we might need someone with such a machine to give us
>> /sys/class/dmi/id/modalias content. Peter, do you have any users with
>> such machines?
> 
> I search my acerhdf-inbox for the people who sent me the BIOS versions, 
> maybe they still have the netbook and can me send the modalias content. 
> I'll hopefully find some time upcoming weekend.
> 
> But, can't we simply assume, following dmi lines?
> 
> MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
> MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
> MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
> MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");
> 
> We have exactly those constellations within the BIOS settings table. If 
> I interpret the modalias line correctly, "pnAOA110" means "Product Name 
> AOA110" and that's what we have already in the BIOS settings table. So I 
> think we do already have all information we need to create a complete 
> patch for the problem, or am I wrong?

Right pn means that. I would strongly believe the above changes should be good. 
I sometimes tend to be over-cautious. Attaching a refreshed patch which 
includes them all.

-Stefan

>>
>>> From 389f61f7e66ce615dc6418cb856e167edaa74b42 Mon Sep 17 00:00:00 2001
>>> From: Stefan Bader <stefan.bader@canonical.com>
>>> Date: Mon, 28 Sep 2009 17:11:29 +0000
>>> Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to 
>>> supported boards
>>>
>>> BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958
>>>
>>> The module alias currently matches any Acer computer but when loaded the
>>> BIOS checks will only succeed on Aspire One models. This causes a 
>>> invalid
>>> BIOS warning for all other models (seen on Aspire 4810T).
>>> This is not fatal but worries users that see this message. Limiting the
>>> moule alias to models starting with AOA. Probably the same change 
>>> should be
>>> made for the two other entries.
>>>
>>> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
>>
>> Acked-by: Borislav Petkov <petkovbb@gmail.com>
>>
>>> ---
>>>  drivers/platform/x86/acerhdf.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/platform/x86/acerhdf.c 
>>> b/drivers/platform/x86/acerhdf.c
>>> index aa298d6..763f233 100644
>>> --- a/drivers/platform/x86/acerhdf.c
>>> +++ b/drivers/platform/x86/acerhdf.c
>>> @@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)
>>>  MODULE_LICENSE("GPL");
>>>  MODULE_AUTHOR("Peter Feuerer");
>>>  MODULE_DESCRIPTION("Aspire One temperature and fan driver");
>>> -MODULE_ALIAS("dmi:*:*Acer*:*:");
>>> +MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
>>>  MODULE_ALIAS("dmi:*:*Gateway*:*:");
>>>  MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
>>>  
>>> -- 
>>> 1.5.4.5
> 
> kind regards,
> --peter


-- 

When all other means of communication fail, try words!



[-- Attachment #2: 0001-acerhdf-Limit-modalias-matching-to-supported-boards.patch --]
[-- Type: text/x-diff, Size: 1505 bytes --]

>From 60cdb7bea856fdd594262ee1e9608cd2210cf196 Mon Sep 17 00:00:00 2001
From: Stefan Bader <stefan.bader@canonical.com>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] acerhdf: Limit modalias matching to supported boards

BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958

The module alias currently matches any Acer computer but when loaded the
BIOS checks will only succeed on Aspire One models. This causes a invalid
BIOS warning for all other models (seen on Aspire 4810T).
This is not fatal but worries users that see this message. Limiting the
moule alias to models starting with AOA or DOA for Packard Bell.

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 drivers/platform/x86/acerhdf.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 0a8f735..23eea4c 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -629,9 +629,10 @@ static void __exit acerhdf_exit(void)
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter Feuerer");
 MODULE_DESCRIPTION("Aspire One temperature and fan driver");
-MODULE_ALIAS("dmi:*:*Acer*:*:");
-MODULE_ALIAS("dmi:*:*Gateway*:*:");
-MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
 
 module_init(acerhdf_init);
 module_exit(acerhdf_exit);
-- 
1.5.4.3

Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Borislav Petkov]

On Fri, Oct 2, 2009 at 9:51 AM, Stefan Bader <stefan.bader@canonical.com> wrote:
>>> I search my acerhdf-inbox for the people who sent me the BIOS versions,
>> maybe they still have the netbook and can me send the modalias content. I'll
>> hopefully find some time upcoming weekend.
>>
>> But, can't we simply assume, following dmi lines?
>>
>> MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
>> MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
>> MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
>> MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");
>>
>> We have exactly those constellations within the BIOS settings table. If I
>> interpret the modalias line correctly, "pnAOA110" means "Product Name
>> AOA110" and that's what we have already in the BIOS settings table. So I
>> think we do already have all information we need to create a complete patch
>> for the problem, or am I wrong?
>
> Right pn means that. I would strongly believe the above changes should be
> good. I sometimes tend to be over-cautious. Attaching a refreshed patch
> which includes them all.

Well, acerhdf.c and dmi-id.c both do
dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which
means that the product names in the acerhdf table and the dmi-id ones
are actually one and the same thing.

IMO, we should just go ahead send it to Len. Stefan, you have my ACK.

-- 
Regards/Gruss,
Boris

Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Peter Feuerer]

Borislav Petkov writes:

> On Fri, Oct 2, 2009 at 9:51 AM, Stefan Bader <stefan.bader@canonical.com> wrote:
>>>> I search my acerhdf-inbox for the people who sent me the BIOS versions,
>>> maybe they still have the netbook and can me send the modalias content. I'll
>>> hopefully find some time upcoming weekend.
>>>
>>> But, can't we simply assume, following dmi lines?
>>>
>>> MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
>>> MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");
>>>
>>> We have exactly those constellations within the BIOS settings table. If I
>>> interpret the modalias line correctly, "pnAOA110" means "Product Name
>>> AOA110" and that's what we have already in the BIOS settings table. So I
>>> think we do already have all information we need to create a complete patch
>>> for the problem, or am I wrong?
>>
>> Right pn means that. I would strongly believe the above changes should be
>> good. I sometimes tend to be over-cautious. Attaching a refreshed patch
>> which includes them all.
> 
> Well, acerhdf.c and dmi-id.c both do
> dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which
> means that the product names in the acerhdf table and the dmi-id ones
> are actually one and the same thing.
> 
> IMO, we should just go ahead send it to Len. Stefan, you have my ACK.

Will try the patch tomorrow morning and you'll then get also my ack, if it's 
working.

--peter

Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Stefan Bader]

Peter Feuerer wrote:
> Borislav Petkov writes:
> 
>> On Fri, Oct 2, 2009 at 9:51 AM, Stefan Bader 
>> <stefan.bader@canonical.com> wrote:
>>>>> I search my acerhdf-inbox for the people who sent me the BIOS 
>>>>> versions,
>>>> maybe they still have the netbook and can me send the modalias 
>>>> content. I'll
>>>> hopefully find some time upcoming weekend.
>>>>
>>>> But, can't we simply assume, following dmi lines?
>>>>
>>>> MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
>>>> MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
>>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
>>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");
>>>>
>>>> We have exactly those constellations within the BIOS settings table. 
>>>> If I
>>>> interpret the modalias line correctly, "pnAOA110" means "Product Name
>>>> AOA110" and that's what we have already in the BIOS settings table. 
>>>> So I
>>>> think we do already have all information we need to create a 
>>>> complete patch
>>>> for the problem, or am I wrong?
>>>
>>> Right pn means that. I would strongly believe the above changes 
>>> should be
>>> good. I sometimes tend to be over-cautious. Attaching a refreshed patch
>>> which includes them all.
>>
>> Well, acerhdf.c and dmi-id.c both do
>> dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which
>> means that the product names in the acerhdf table and the dmi-id ones
>> are actually one and the same thing.
>>
>> IMO, we should just go ahead send it to Len. Stefan, you have my ACK.
> 
> Will try the patch tomorrow morning and you'll then get also my ack, if 
> it's working.
> 
> --peter

Ok, cool. Will wait on that.

-Stefan

-- 

When all other means of communication fail, try words!

Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Peter Feuerer]

Stefan Bader writes:

> Peter Feuerer wrote:
>> Borislav Petkov writes:
>> 
>>> On Fri, Oct 2, 2009 at 9:51 AM, Stefan Bader 
>>> <stefan.bader@canonical.com> wrote:
>>>>>> I search my acerhdf-inbox for the people who sent me the BIOS 
>>>>>> versions,
>>>>> maybe they still have the netbook and can me send the modalias 
>>>>> content. I'll
>>>>> hopefully find some time upcoming weekend.
>>>>>
>>>>> But, can't we simply assume, following dmi lines?
>>>>>
>>>>> MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
>>>>> MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
>>>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
>>>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");
>>>>>
>>>>> We have exactly those constellations within the BIOS settings table. 
>>>>> If I
>>>>> interpret the modalias line correctly, "pnAOA110" means "Product Name
>>>>> AOA110" and that's what we have already in the BIOS settings table. 
>>>>> So I
>>>>> think we do already have all information we need to create a 
>>>>> complete patch
>>>>> for the problem, or am I wrong?
>>>>
>>>> Right pn means that. I would strongly believe the above changes 
>>>> should be
>>>> good. I sometimes tend to be over-cautious. Attaching a refreshed patch
>>>> which includes them all.
>>>
>>> Well, acerhdf.c and dmi-id.c both do
>>> dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which
>>> means that the product names in the acerhdf table and the dmi-id ones
>>> are actually one and the same thing.
>>>
>>> IMO, we should just go ahead send it to Len. Stefan, you have my ACK.

Acked-by: Peter Feuerer <peter@piie.net>

Thank you Stefan!

regards,
--peter

Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Peter Feuerer]

Bjorn Helgaas writes:

> On Monday 05 October 2009 09:56:51 am Stefan Bader wrote:
>> Bjorn Helgaas wrote:
>> > On Monday 05 October 2009 06:05:54 am Stefan Bader wrote:
>> >>>>>> <stefan.bader@canonical.com> wrote:
>> >>>>>>>>> I search my acerhdf-inbox for the people who sent me the BIOS 
>> >>>>>>>>> versions,
>> >>>>>>>> maybe they still have the netbook and can me send the modalias 
>> >>>>>>>> content. I'll

...

>> > 
>> > This smells like a maintenance problem.  The driver only works on the
>> > specific machines and BIOS versions compiled into it.  That means you
>> > have to update the driver every time a new machine comes out.  A major
>> > goal of ACPI is to avoid stuff like that.
>> > 
>> > Are you sure there's no way to make this driver work in a generic way,
>> > e.g., by claiming an ACPI device?
>> 
>> The driver is currently only targeted at a small set of netbooks and even there 
>> some registers have changed between sub models or bios versions.
>> The functions are implemented by poking and reading bits from the EC. No acpi 
>> interface to which one relate as far as I know. Maybe wmi, but from the 
>> experiences with acer-wmi, I doubt anything works. At least acer-wmi now 
>> explicitly blacklist these models for uselessness.
>> So the driver performs very strict bios version checks and every unknown 
>> version get a big warning printed. Which you do not want to be issued on every 
>> hardware of one of these vendors. Which happens with the driver as it is now.
> 
> I understand the motivation for the current patch, and I'm not asking
> about it in particular.  My concern is about the underlying structure
> of the driver.
> 
> I'm just asking why we would want a driver that requires an update
> for every new machine.  That sort of ongoing maintenance is a good
> sign that we're doing something wrong.

Hi Bjorn,

as Stefan already mentioned, is the driver only targeting a very small set 
of (very popular) netbooks. The vendor supposed to control the fan only by 
BIOS. I think it is not ment to be controlled by the OS at all, as there is 
no official Windows support neither.
The successor series of the supported netbooks even don't have the 
register in EC anymore. So I think there won't be much changes caused by new 
devices in the future anymore. Besides that, I don't think there's a way to 
detect the right register and the needed values automatically…

kind regards,
--peter
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html