Fix boolean handling in semanage

Fix boolean handling in semanage

[Daniel J Walsh]

[-- Attachment #1: Type: text/plain, Size: 62 bytes --]

Also fix error message triggered by broken boolean handling.


[-- Attachment #2: booleans.patch --]
[-- Type: text/plain, Size: 708 bytes --]

diff --git a/policycoreutils/semanage/semanage b/policycoreutils/semanage/semanage
index ffaca5b..437eca3 100644
--- a/policycoreutils/semanage/semanage
+++ b/policycoreutils/semanage/semanage
@@ -315,6 +315,7 @@ Object-specific Options (see above):
 		
 		if object == "boolean":
 			OBJECT = seobject.booleanRecords(store)
+                        modify = True
 		
 		if object == "permissive":
 			OBJECT = seobject.permissiveRecords(store)
@@ -404,7 +405,7 @@ Object-specific Options (see above):
 
                         return
 
-                raise ValueError(_("Invalid command") % " ".join(argv))
+                raise ValueError(_("Invalid command: semanage %s") % " ".join(argv))
 
 	#
 	# 

Re: Fix boolean handling in semanage

[Chad Sellers]

On 9/30/09 2:23 PM, "Daniel J Walsh" <dwalsh@redhat.com> wrote:

> Also fix error message triggered by broken boolean handling.
> 
> diff --git a/policycoreutils/semanage/semanage
> b/policycoreutils/semanage/semanage
> index ffaca5b..437eca3 100644
> --- a/policycoreutils/semanage/semanage
> +++ b/policycoreutils/semanage/semanage
> @@ -315,6 +315,7 @@ Object-specific Options (see above):
>          
>          if object == "boolean":
>              OBJECT = seobject.booleanRecords(store)
> +                        modify = True
>          
Not sure I see what was broken here. The usage and man page say you have to
specify -d or -m to semanage boolean (which is just like all the other
subcommands). Here you're trying to make that optional, and default to -m if
not specified (unless I'm guessing wrong at your intentions). I'd be fine
with that, but you broke -d in the process:

# semanage boolean -d xen_use_nfs
Traceback (most recent call last):
  File "/usr/sbin/semanage", line 461, in <module>
    process_args(sys.argv[1:])
  File "/usr/sbin/semanage", line 370, in process_args
    OBJECT.modify(target, value, use_file)
  File "/usr/lib/python2.6/site-packages/seobject.py", line 1642, in modify
    self.__mod(name, value)
  File "/usr/lib/python2.6/site-packages/seobject.py", line 1610, in __mod
    if value.upper() in self.dict:
AttributeError: 'NoneType' object has no attribute 'upper'

>          if object == "permissive":
>              OBJECT = seobject.permissiveRecords(store)
> @@ -404,7 +405,7 @@ Object-specific Options (see above):
>  
>                          return
>  
> -                raise ValueError(_("Invalid command") % " ".join(argv))
> +                raise ValueError(_("Invalid command: semanage %s") % "
> ".join(argv))
>  
>      #
>      # 
> 
> 


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.