[PATCH] Remove an unnecessary check on socket restart

[PATCH] Remove an unnecessary check on socket restart

[Dan Smith]

This check is removed because it cannot be true because of the
unsigned nature of the value being examined.

Signed-off-by: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
Cc: orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org
---
 net/checkpoint.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/checkpoint.c b/net/checkpoint.c
index a11ec7a..0087a8a 100644
--- a/net/checkpoint.c
+++ b/net/checkpoint.c
@@ -484,8 +484,7 @@ static int sock_cptrst(struct ckpt_ctx *ctx, struct sock *sk,
 		   (h->sock.state >= TCP_MAX_STATES)) {
 		ckpt_debug("sock in invalid state: %i", h->sock.state);
 		return -EINVAL;
-	} else if ((h->socket.state < SS_FREE) ||
-		   (h->socket.state > SS_DISCONNECTING)) {
+	} else if (h->socket.state > SS_DISCONNECTING) {
 		ckpt_debug("socket in invalid state: %i",
 			   h->socket.state);
 		return -EINVAL;
-- 
1.6.0.4

Re: [PATCH] Remove an unnecessary check on socket restart

[Serge E. Hallyn]

Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> This check is removed because it cannot be true because of the
> unsigned nature of the value being examined.
> 
> Signed-off-by: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Thanks.  I actually do keep missing real errors bc of the
noise (most of which comes from cred.h :( ), so I appreciate
every bit they can be reduced.

Acked-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>


> Cc: serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
> Cc: orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org
> ---
>  net/checkpoint.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/checkpoint.c b/net/checkpoint.c
> index a11ec7a..0087a8a 100644
> --- a/net/checkpoint.c
> +++ b/net/checkpoint.c
> @@ -484,8 +484,7 @@ static int sock_cptrst(struct ckpt_ctx *ctx, struct sock *sk,
>  		   (h->sock.state >= TCP_MAX_STATES)) {
>  		ckpt_debug("sock in invalid state: %i", h->sock.state);
>  		return -EINVAL;
> -	} else if ((h->socket.state < SS_FREE) ||
> -		   (h->socket.state > SS_DISCONNECTING)) {
> +	} else if (h->socket.state > SS_DISCONNECTING) {
>  		ckpt_debug("socket in invalid state: %i",
>  			   h->socket.state);
>  		return -EINVAL;
> -- 
> 1.6.0.4

Re: [PATCH] Remove an unnecessary check on socket restart

[Oren Laadan]

To appear in ckpt-v18-dev, thanks.

Dan Smith wrote:
> This check is removed because it cannot be true because of the
> unsigned nature of the value being examined.
> 
> Signed-off-by: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> Cc: serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
> Cc: orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org
> ---
>  net/checkpoint.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/checkpoint.c b/net/checkpoint.c
> index a11ec7a..0087a8a 100644
> --- a/net/checkpoint.c
> +++ b/net/checkpoint.c
> @@ -484,8 +484,7 @@ static int sock_cptrst(struct ckpt_ctx *ctx, struct sock *sk,
>  		   (h->sock.state >= TCP_MAX_STATES)) {
>  		ckpt_debug("sock in invalid state: %i", h->sock.state);
>  		return -EINVAL;
> -	} else if ((h->socket.state < SS_FREE) ||
> -		   (h->socket.state > SS_DISCONNECTING)) {
> +	} else if (h->socket.state > SS_DISCONNECTING) {
>  		ckpt_debug("socket in invalid state: %i",
>  			   h->socket.state);
>  		return -EINVAL;