* [PATCH] omap_hsmmc: Add missing probe handler hook to platform driver data
@ 2009-10-01 14:39 Roger Quadros
2009-10-01 20:08 ` [APPLIED] [PATCH] omap_hsmmc: Add missing probe handler hook to platform Tony Lindgren
[not found] ` <200910011758.35779.rok@kanardia.eu>
0 siblings, 2 replies; 3+ messages in thread
From: Roger Quadros @ 2009-10-01 14:39 UTC (permalink / raw)
To: madhu.cr; +Cc: linux-omap, ext-roger.quadros
The missing probe handler hook will never probe the driver. Add it back.
Fixes broken MMC on OMAP.
Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
---
drivers/mmc/host/omap_hsmmc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 4487cc0..26abe1e 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2001,6 +2001,7 @@ clk_en_err:
#endif
static struct platform_driver omap_hsmmc_driver = {
+ .probe = omap_hsmmc_probe,
.remove = omap_hsmmc_remove,
.suspend = omap_hsmmc_suspend,
.resume = omap_hsmmc_resume,
--
1.6.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [APPLIED] [PATCH] omap_hsmmc: Add missing probe handler hook to platform
2009-10-01 14:39 [PATCH] omap_hsmmc: Add missing probe handler hook to platform driver data Roger Quadros
@ 2009-10-01 20:08 ` Tony Lindgren
[not found] ` <200910011758.35779.rok@kanardia.eu>
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2009-10-01 20:08 UTC (permalink / raw)
To: linux-omap
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Branch in linux-omap: omap-fixes-testing
Initial commit ID (Likely to change): ff50faceca4c78184af7087e2368a5c869688755
PatchWorks
http://patchwork.kernel.org/patch/50970/
Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=ff50faceca4c78184af7087e2368a5c869688755
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] omap_hsmmc: Add missing probe handler hook to platform driver data
[not found] ` <200910011758.35779.rok@kanardia.eu>
@ 2009-10-02 11:47 ` Roger Quadros
0 siblings, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2009-10-02 11:47 UTC (permalink / raw)
To: ext Rok Markovič, linux-omap@vger.kernel.org; +Cc: madhu.cr
ext Rok Markovič wrote:
> This is not the correct way to do it. There was some conflict during merge in
> init function. Correct patch should look like this:
>
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
> static int __init omap_hsmmc_init(void)
> {
> /* Register the MMC driver */
> - return platform_driver_register(&omap_hsmmc_driver);
> + return platform_driver_probe(&omap_hsmmc_driver, omap_hsmmc_probe);
> }
>
> static void __exit omap_hsmmc_cleanup(void)
>
> Rok
>
Oh yes. Since omap_hsmmc is not a hot-pluggable device.
Will send a v2.
Thanks Rok, for pointing this out.
>
>
> Dne četrtek 1. oktobra 2009 ob 16:39:13 ste napisali:
>> The missing probe handler hook will never probe the driver. Add it back.
>> Fixes broken MMC on OMAP.
>>
>> Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
>> ---
>> drivers/mmc/host/omap_hsmmc.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>> index 4487cc0..26abe1e 100644
>> --- a/drivers/mmc/host/omap_hsmmc.c
>> +++ b/drivers/mmc/host/omap_hsmmc.c
>> @@ -2001,6 +2001,7 @@ clk_en_err:
>> #endif
>>
>> static struct platform_driver omap_hsmmc_driver = {
>> + .probe = omap_hsmmc_probe,
>> .remove = omap_hsmmc_remove,
>> .suspend = omap_hsmmc_suspend,
>> .resume = omap_hsmmc_resume,
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-02 11:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-01 14:39 [PATCH] omap_hsmmc: Add missing probe handler hook to platform driver data Roger Quadros
2009-10-01 20:08 ` [APPLIED] [PATCH] omap_hsmmc: Add missing probe handler hook to platform Tony Lindgren
[not found] ` <200910011758.35779.rok@kanardia.eu>
2009-10-02 11:47 ` [PATCH] omap_hsmmc: Add missing probe handler hook to platform driver data Roger Quadros
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.