* lighttpd 1.4.18 runtime issue @ 2009-10-05 18:52 Michael Lippautz 2009-10-05 19:27 ` Phil Blundell 2009-10-05 19:31 ` Marcin Juszkiewicz 0 siblings, 2 replies; 10+ messages in thread From: Michael Lippautz @ 2009-10-05 18:52 UTC (permalink / raw) To: openembedded-devel hej, lighttpd_1.4.18 is installed with a config that should actually load its module mod-indexfile.so. Since the config is pretty default, I added the module to the runtime depends. (also re-formated recipe, uses tabs now). Regards, Michael diff --git a/recipes/lighttpd/lighttpd_1.4.18.bb b/recipes/lighttpd/lighttpd_1.4.18.bb index d5870ba..80d22bc 100644 --- a/recipes/lighttpd/lighttpd_1.4.18.bb +++ b/recipes/lighttpd/lighttpd_1.4.18.bb @@ -2,26 +2,31 @@ DESCRIPTION = "Web server" SECTION = "net" LICENSE = "BSD" DEPENDS = "libpcre" -PR = "r3" - -SRC_URI = "http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \ - file://configure.in.patch;patch=1 \ - file://mod_redirect.c.patch;patch=1 \ - file://src-server.c.patch;patch=1 \ - file://index.html \ - file://lighttpd.conf \ - file://lighttpd" - -EXTRA_OECONF="--without-bzip2 \ - --without-ldap \ - --without-lua \ - --without-memcache \ - --with-pcre \ - --without-webdav-props \ - --without-webdav-locks \ - --without-openssl \ - --disable-nls \ - --disable-static" +PR = "r4" + +RDEPENDS_${PN} += " \ + lighttpd-module-indexfile" + +SRC_URI = " \ + http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \ + file://configure.in.patch;patch=1 \ + file://mod_redirect.c.patch;patch=1 \ + file://src-server.c.patch;patch=1 \ + file://index.html \ + file://lighttpd.conf \ + file://lighttpd" + +EXTRA_OECONF=" \ + --without-bzip2 \ + --without-ldap \ + --without-lua \ + --without-memcache \ + --with-pcre \ + --without-webdav-props \ + --without-webdav-locks \ + --without-openssl \ + --disable-nls \ + --disable-static" inherit autotools pkgconfig update-rc.d @@ -44,6 +49,6 @@ FILES_${PN} += "${sysconfdir} /www" PACKAGES_DYNAMIC = "lighttpd-module-*" python populate_packages_prepend () { - lighttpd_libdir = bb.data.expand('${libdir}', d) - do_split_packages(d, lighttpd_libdir, '^mod_(.*)\.so$', 'lighttpd-module-%s', 'Lighttpd module for %s', extra_depends='') + lighttpd_libdir = bb.data.expand('${libdir}', d) + do_split_packages(d, lighttpd_libdir, '^mod_(.*)\.so$', 'lighttpd-module-%s', 'Lighttpd module for %s', extra_depends='') } ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: lighttpd 1.4.18 runtime issue 2009-10-05 18:52 lighttpd 1.4.18 runtime issue Michael Lippautz @ 2009-10-05 19:27 ` Phil Blundell 2009-10-05 20:25 ` Michael Lippautz 2009-10-05 19:31 ` Marcin Juszkiewicz 1 sibling, 1 reply; 10+ messages in thread From: Phil Blundell @ 2009-10-05 19:27 UTC (permalink / raw) To: openembedded-devel Thanks for the patch. For future reference, please don't combine mechanical operations like reformatting with other edits in a single patch. It makes it much harder to see what the patch is actually doing if there is a lot of other extraneous noise going on. Can you clarify what the effect is of failing to install lighttpd-module-indexfile; does the daemon just refuse to start at all, or does it just ignore the config file directive if the module is missing? If the latter, and/or if folks are likely to edit the config file to remove the reference to that module, it might be better to set the module package as RRECOMMENDS rather than RDEPENDS. p. On Mon, 2009-10-05 at 20:52 +0200, Michael Lippautz wrote: > hej, > > lighttpd_1.4.18 is installed with a config that should actually load its > module mod-indexfile.so. > > Since the config is pretty default, I added the module to the runtime > depends. (also re-formated recipe, uses tabs now). > > Regards, > Michael > > > diff --git a/recipes/lighttpd/lighttpd_1.4.18.bb > b/recipes/lighttpd/lighttpd_1.4.18.bb > index d5870ba..80d22bc 100644 > --- a/recipes/lighttpd/lighttpd_1.4.18.bb > +++ b/recipes/lighttpd/lighttpd_1.4.18.bb > @@ -2,26 +2,31 @@ DESCRIPTION = "Web server" > SECTION = "net" > LICENSE = "BSD" > DEPENDS = "libpcre" > -PR = "r3" > - > -SRC_URI = "http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \ > - file://configure.in.patch;patch=1 \ > - file://mod_redirect.c.patch;patch=1 \ > - file://src-server.c.patch;patch=1 \ > - file://index.html \ > - file://lighttpd.conf \ > - file://lighttpd" > - > -EXTRA_OECONF="--without-bzip2 \ > - --without-ldap \ > - --without-lua \ > - --without-memcache \ > - --with-pcre \ > - --without-webdav-props \ > - --without-webdav-locks \ > - --without-openssl \ > - --disable-nls \ > - --disable-static" > +PR = "r4" > + > +RDEPENDS_${PN} += " \ > + lighttpd-module-indexfile" > + > +SRC_URI = " \ > + http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \ > + file://configure.in.patch;patch=1 \ > + file://mod_redirect.c.patch;patch=1 \ > + file://src-server.c.patch;patch=1 \ > + file://index.html \ > + file://lighttpd.conf \ > + file://lighttpd" > + > +EXTRA_OECONF=" \ > + --without-bzip2 \ > + --without-ldap \ > + --without-lua \ > + --without-memcache \ > + --with-pcre \ > + --without-webdav-props \ > + --without-webdav-locks \ > + --without-openssl \ > + --disable-nls \ > + --disable-static" > > inherit autotools pkgconfig update-rc.d > > @@ -44,6 +49,6 @@ FILES_${PN} += "${sysconfdir} /www" > PACKAGES_DYNAMIC = "lighttpd-module-*" > > python populate_packages_prepend () { > - lighttpd_libdir = bb.data.expand('${libdir}', d) > - do_split_packages(d, lighttpd_libdir, '^mod_(.*)\.so$', > 'lighttpd-module-%s', 'Lighttpd module for %s', extra_depends='') > + lighttpd_libdir = bb.data.expand('${libdir}', d) > + do_split_packages(d, lighttpd_libdir, '^mod_(.*)\.so$', > 'lighttpd-module-%s', 'Lighttpd module for %s', extra_depends='') > } > > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: lighttpd 1.4.18 runtime issue 2009-10-05 19:27 ` Phil Blundell @ 2009-10-05 20:25 ` Michael Lippautz 2009-10-05 22:59 ` Otavio Salvador 0 siblings, 1 reply; 10+ messages in thread From: Michael Lippautz @ 2009-10-05 20:25 UTC (permalink / raw) To: openembedded-devel After further investigation, I found a document (${S}/doc/configuration.txt) that states: ... Starting with lighttpd 1.4.0 three default modules are loaded automaticly: - mod_indexfile - mod_dirlisting - mod_staticfile ... The daemon did not start at all because it failed the module initialization process. (Got no exact error messages, because I have no access to the board atm.) The modules cannot be deactivated in the config. After all, I think an RDEPENDS would be appropriate here. git diff (without any formatting changes) is attached. Regards, Michael diff --git a/recipes/lighttpd/lighttpd_1.4.18.bb b/recipes/lighttpd/lighttpd_1.4.18.bb index d5870ba..a446122 100644 --- a/recipes/lighttpd/lighttpd_1.4.18.bb +++ b/recipes/lighttpd/lighttpd_1.4.18.bb @@ -2,7 +2,12 @@ DESCRIPTION = "Web server" SECTION = "net" LICENSE = "BSD" DEPENDS = "libpcre" -PR = "r3" +RDEPENDS_${PN} += " \ + lighttpd-module-indexfile \ + lighttpd-module-dirlisting \ + lighttpd-module-staticfile" + +PR = "r4" SRC_URI = "http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \ file://configure.in.patch;patch=1 \ Am Montag, den 05.10.2009, 20:27 +0100 schrieb Phil Blundell: > Thanks for the patch. > > For future reference, please don't combine mechanical operations like > reformatting with other edits in a single patch. It makes it much > harder to see what the patch is actually doing if there is a lot of > other extraneous noise going on. > > Can you clarify what the effect is of failing to install > lighttpd-module-indexfile; does the daemon just refuse to start at all, > or does it just ignore the config file directive if the module is > missing? If the latter, and/or if folks are likely to edit the config > file to remove the reference to that module, it might be better to set > the module package as RRECOMMENDS rather than RDEPENDS. > > p. > > On Mon, 2009-10-05 at 20:52 +0200, Michael Lippautz wrote: > > hej, > > > > lighttpd_1.4.18 is installed with a config that should actually load its > > module mod-indexfile.so. > > > > Since the config is pretty default, I added the module to the runtime > > depends. (also re-formated recipe, uses tabs now). > > > > Regards, > > Michael > > > > > > diff --git a/recipes/lighttpd/lighttpd_1.4.18.bb > > b/recipes/lighttpd/lighttpd_1.4.18.bb > > index d5870ba..80d22bc 100644 > > --- a/recipes/lighttpd/lighttpd_1.4.18.bb > > +++ b/recipes/lighttpd/lighttpd_1.4.18.bb > > @@ -2,26 +2,31 @@ DESCRIPTION = "Web server" > > SECTION = "net" > > LICENSE = "BSD" > > DEPENDS = "libpcre" > > -PR = "r3" > > - > > -SRC_URI = "http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \ > > - file://configure.in.patch;patch=1 \ > > - file://mod_redirect.c.patch;patch=1 \ > > - file://src-server.c.patch;patch=1 \ > > - file://index.html \ > > - file://lighttpd.conf \ > > - file://lighttpd" > > - > > -EXTRA_OECONF="--without-bzip2 \ > > - --without-ldap \ > > - --without-lua \ > > - --without-memcache \ > > - --with-pcre \ > > - --without-webdav-props \ > > - --without-webdav-locks \ > > - --without-openssl \ > > - --disable-nls \ > > - --disable-static" > > +PR = "r4" > > + > > +RDEPENDS_${PN} += " \ > > + lighttpd-module-indexfile" > > + > > +SRC_URI = " \ > > + http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \ > > + file://configure.in.patch;patch=1 \ > > + file://mod_redirect.c.patch;patch=1 \ > > + file://src-server.c.patch;patch=1 \ > > + file://index.html \ > > + file://lighttpd.conf \ > > + file://lighttpd" > > + > > +EXTRA_OECONF=" \ > > + --without-bzip2 \ > > + --without-ldap \ > > + --without-lua \ > > + --without-memcache \ > > + --with-pcre \ > > + --without-webdav-props \ > > + --without-webdav-locks \ > > + --without-openssl \ > > + --disable-nls \ > > + --disable-static" > > > > inherit autotools pkgconfig update-rc.d > > > > @@ -44,6 +49,6 @@ FILES_${PN} += "${sysconfdir} /www" > > PACKAGES_DYNAMIC = "lighttpd-module-*" > > > > python populate_packages_prepend () { > > - lighttpd_libdir = bb.data.expand('${libdir}', d) > > - do_split_packages(d, lighttpd_libdir, '^mod_(.*)\.so$', > > 'lighttpd-module-%s', 'Lighttpd module for %s', extra_depends='') > > + lighttpd_libdir = bb.data.expand('${libdir}', d) > > + do_split_packages(d, lighttpd_libdir, '^mod_(.*)\.so$', > > 'lighttpd-module-%s', 'Lighttpd module for %s', extra_depends='') > > } > > > > > > > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: lighttpd 1.4.18 runtime issue 2009-10-05 20:25 ` Michael Lippautz @ 2009-10-05 22:59 ` Otavio Salvador 2009-10-06 9:16 ` Michael Lippautz 0 siblings, 1 reply; 10+ messages in thread From: Otavio Salvador @ 2009-10-05 22:59 UTC (permalink / raw) To: openembedded-devel Hello Michael, On Mon, Oct 5, 2009 at 5:25 PM, Michael Lippautz <michael.lippautz@gmail.com> wrote: > After further investigation, I found a document > (${S}/doc/configuration.txt) that states: The best way to provide the patch is to commit it locally and use git format-patch to export it. Then send it attached to the mail. -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: lighttpd 1.4.18 runtime issue 2009-10-05 22:59 ` Otavio Salvador @ 2009-10-06 9:16 ` Michael Lippautz 2009-10-08 0:46 ` Otavio Salvador 0 siblings, 1 reply; 10+ messages in thread From: Michael Lippautz @ 2009-10-06 9:16 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 251 bytes --] Am Montag, den 05.10.2009, 19:59 -0300 schrieb Otavio Salvador: > The best way to provide the patch is to commit it locally and use git > format-patch to export it. Then send it attached to the mail. Thx for all the infos. Here's the patch. [-- Attachment #2: 0001-lighttpd-1.4.18-Fixed-missing-runtime-module-depende.patch --] [-- Type: text/x-patch, Size: 1022 bytes --] From fc5de54141069d3c6ef8a15783563123e1c479d1 Mon Sep 17 00:00:00 2001 From: Michael Lippautz <michael.lippautz@gmail.com> Date: Tue, 6 Oct 2009 11:04:04 +0200 Subject: [PATCH] lighttpd 1.4.18: Fixed missing runtime module dependencies Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com> --- recipes/lighttpd/lighttpd_1.4.18.bb | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/recipes/lighttpd/lighttpd_1.4.18.bb b/recipes/lighttpd/lighttpd_1.4.18.bb index d5870ba..a446122 100644 --- a/recipes/lighttpd/lighttpd_1.4.18.bb +++ b/recipes/lighttpd/lighttpd_1.4.18.bb @@ -2,7 +2,12 @@ DESCRIPTION = "Web server" SECTION = "net" LICENSE = "BSD" DEPENDS = "libpcre" -PR = "r3" +RDEPENDS_${PN} += " \ + lighttpd-module-indexfile \ + lighttpd-module-dirlisting \ + lighttpd-module-staticfile" + +PR = "r4" SRC_URI = "http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \ file://configure.in.patch;patch=1 \ -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: lighttpd 1.4.18 runtime issue 2009-10-06 9:16 ` Michael Lippautz @ 2009-10-08 0:46 ` Otavio Salvador 2009-10-08 12:17 ` Michael Lippautz 0 siblings, 1 reply; 10+ messages in thread From: Otavio Salvador @ 2009-10-08 0:46 UTC (permalink / raw) To: openembedded-devel Hello, On Tue, Oct 6, 2009 at 6:16 AM, Michael Lippautz <michael.lippautz@gmail.com> wrote: > Am Montag, den 05.10.2009, 19:59 -0300 schrieb Otavio Salvador: >> The best way to provide the patch is to commit it locally and use git >> format-patch to export it. Then send it attached to the mail. > > Thx for all the infos. Here's the patch. In meanwhile it looks to have been fixed in current master; would be nice if you could test it and provide a updated patch if still needed. -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: lighttpd 1.4.18 runtime issue 2009-10-08 0:46 ` Otavio Salvador @ 2009-10-08 12:17 ` Michael Lippautz 2009-10-08 20:08 ` Henning Heinold 0 siblings, 1 reply; 10+ messages in thread From: Michael Lippautz @ 2009-10-08 12:17 UTC (permalink / raw) To: openembedded-devel 2009/10/8 Otavio Salvador <otavio@ossystems.com.br>: > In meanwhile it looks to have been fixed in current master; would be > nice if you could test it and provide a updated patch if still needed. I actually tested the build today. Unfortunatelly there is still an issue remaining. The patch fixed the automatically loaded modules, but missed that there are still two modules loaded on startup in the config that is shipped. These modules are module-access and module-accesslog. (Actually I missed them when I wrote the patch, sorry for that.) Since the config states that these modules "should" be loaded, it has to be decided whether OE goes with this recommendation and adds the additional two modules as runtime dep., OR just strips/uncomments the specific sections in the config. Regards, Michael ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: lighttpd 1.4.18 runtime issue 2009-10-08 12:17 ` Michael Lippautz @ 2009-10-08 20:08 ` Henning Heinold 0 siblings, 0 replies; 10+ messages in thread From: Henning Heinold @ 2009-10-08 20:08 UTC (permalink / raw) To: openembedded-devel On Thu, Oct 08, 2009 at 02:17:25PM +0200, Michael Lippautz wrote: > 2009/10/8 Otavio Salvador <otavio@ossystems.com.br>: > > In meanwhile it looks to have been fixed in current master; would be > > nice if you could test it and provide a updated patch if still needed. > > I actually tested the build today. Unfortunatelly there is still an > issue remaining. > The patch fixed the automatically loaded modules, but missed that > there are still two modules loaded on startup in the config that is > shipped. These modules are module-access and module-accesslog. > (Actually I missed them when I wrote the patch, sorry for that.) > > Since the config states that these modules "should" be loaded, it has > to be decided whether OE goes with this recommendation and adds the > additional two modules as runtime dep., OR just strips/uncomments the > specific sections in the config. > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel So what you like? I will do it *g*. Bye Henning ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: lighttpd 1.4.18 runtime issue 2009-10-05 18:52 lighttpd 1.4.18 runtime issue Michael Lippautz 2009-10-05 19:27 ` Phil Blundell @ 2009-10-05 19:31 ` Marcin Juszkiewicz 2009-10-05 19:46 ` Michael Lippautz 1 sibling, 1 reply; 10+ messages in thread From: Marcin Juszkiewicz @ 2009-10-05 19:31 UTC (permalink / raw) To: openembedded-devel Dnia poniedziałek, 5 października 2009 o 20:52:13 Michael Lippautz napisał(a): > lighttpd_1.4.18 is installed with a config that should actually load its > module mod-indexfile.so. > Since the config is pretty default, I added the module to the runtime > depends. OK > (also re-formated recipe, uses tabs now). There is a tool in contrib/ which handle reformation of recipes. # _Format guideline #2_: # Tabs should not be used (use spaces instead). You have tab=8, I use tab=4 for most of formats so we get different view of recipe code... Regards, -- JID: hrw@jabber.org Website: http://marcin.juszkiewicz.com.pl/ LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: lighttpd 1.4.18 runtime issue 2009-10-05 19:31 ` Marcin Juszkiewicz @ 2009-10-05 19:46 ` Michael Lippautz 0 siblings, 0 replies; 10+ messages in thread From: Michael Lippautz @ 2009-10-05 19:46 UTC (permalink / raw) To: openembedded-devel Sorry, was refering to http://wiki.openembedded.net/index.php/Styleguide stating that either tabs or spaces should be used. This recipe was mixing both. Will use spaces and the tool (didn't see the wiki headline) in future recipes. Regards, Michael Marcin Juszkiewicz schrieb: > Dnia poniedziałek, 5 października 2009 o 20:52:13 Michael Lippautz napisał(a): > >> lighttpd_1.4.18 is installed with a config that should actually load its >> module mod-indexfile.so. >> > > >> Since the config is pretty default, I added the module to the runtime >> depends. >> > > OK > > >> (also re-formated recipe, uses tabs now). >> > > There is a tool in contrib/ which handle reformation of recipes. > > # _Format guideline #2_: > # Tabs should not be used (use spaces instead). > > You have tab=8, I use tab=4 for most of formats so we get different view of > recipe code... > > Regards, > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-10-08 20:09 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-10-05 18:52 lighttpd 1.4.18 runtime issue Michael Lippautz 2009-10-05 19:27 ` Phil Blundell 2009-10-05 20:25 ` Michael Lippautz 2009-10-05 22:59 ` Otavio Salvador 2009-10-06 9:16 ` Michael Lippautz 2009-10-08 0:46 ` Otavio Salvador 2009-10-08 12:17 ` Michael Lippautz 2009-10-08 20:08 ` Henning Heinold 2009-10-05 19:31 ` Marcin Juszkiewicz 2009-10-05 19:46 ` Michael Lippautz
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.