* [PATCH] ixj: Fix test in ixj_selfprobe()
@ 2009-10-06 15:47 Roel Kluin
2009-10-13 23:54 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-10-06 15:47 UTC (permalink / raw)
To: Andrew Morton, LKML
Not makes it a bool before the comparison.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Was below intended?
diff --git a/drivers/telephony/ixj.c b/drivers/telephony/ixj.c
index 40de151..da3c9a0 100644
--- a/drivers/telephony/ixj.c
+++ b/drivers/telephony/ixj.c
@@ -6831,7 +6831,7 @@ static int ixj_selfprobe(IXJ *j)
} else {
switch (j->cardtype) {
case QTI_PHONEJACK:
- if (!j->dsp.low != 0x20) {
+ if (j->dsp.low != 0x20) {
j->dsp.high = 0x80;
j->dsp.low = 0x20;
ixj_WriteDSPCommand(0x3800, j);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ixj: Fix test in ixj_selfprobe()
2009-10-06 15:47 [PATCH] ixj: Fix test in ixj_selfprobe() Roel Kluin
@ 2009-10-13 23:54 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2009-10-13 23:54 UTC (permalink / raw)
To: Roel Kluin; +Cc: LKML
On Tue, 06 Oct 2009 17:47:16 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:
> Not makes it a bool before the comparison.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Was below intended?
>
> diff --git a/drivers/telephony/ixj.c b/drivers/telephony/ixj.c
> index 40de151..da3c9a0 100644
> --- a/drivers/telephony/ixj.c
> +++ b/drivers/telephony/ixj.c
> @@ -6831,7 +6831,7 @@ static int ixj_selfprobe(IXJ *j)
> } else {
> switch (j->cardtype) {
> case QTI_PHONEJACK:
> - if (!j->dsp.low != 0x20) {
> + if (j->dsp.low != 0x20) {
> j->dsp.high = 0x80;
> j->dsp.low = 0x20;
> ixj_WriteDSPCommand(0x3800, j);
gee, I can't tell. Presumably it'd be safer to just delete the test -
it's a no-op at present and that code is well-tested, lol.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-13 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-06 15:47 [PATCH] ixj: Fix test in ixj_selfprobe() Roel Kluin
2009-10-13 23:54 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.