From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: {} as in linux kernel
Date: Tue, 06 Oct 2009 16:43:42 -0500 [thread overview]
Message-ID: <4ACBBA0E.7040905@codemonkey.ws> (raw)
In-Reply-To: <4ACBB1B5.7010704@mail.berlios.de>
Stefan Weil wrote:
> Michael S. Tsirkin schrieb:
>
>> Most people seem to hate using {} around sngle-statement blocks.
>> And code isn't consistent either way. So let's change our standard
>> to something most people like, and eliminate the pain source.
>>
>>
>>
>
> Inconsistency is not an argument for or against {}.
> I don't like single statement blocks without {}
> because of my personal experience with all kinds
> of code standard variants.
>
> Please don't change the qemu standard, I like it as it is.
>
I've never liked this but I would rather not see unnecessary churn so
I'd prefer to keep the coding style as-is.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-10-06 21:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 19:01 [Qemu-devel] [PATCH] CODING_STYLE: {} as in linux kernel Michael S. Tsirkin
2009-10-06 21:08 ` Stefan Weil
2009-10-06 21:43 ` Anthony Liguori [this message]
2009-10-07 12:59 ` Markus Armbruster
2009-10-06 21:41 ` Stuart Brady
2009-10-07 9:11 ` Jamie Lokier
2009-10-07 14:12 ` Kevin Wolf
2009-10-07 14:54 ` Gerd Hoffmann
2009-10-07 17:09 ` Stuart Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACBBA0E.7040905@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.