Re: [Qemu-devel] [PATCH] CODING_STYLE: {} as in linux kernel

[Markus Armbruster <armbru@redhat.com>]

Anthony Liguori <anthony@codemonkey.ws> writes:

> Stefan Weil wrote:
>> Michael S. Tsirkin schrieb:
>>   
>>> Most people seem to hate using {} around sngle-statement blocks.
>>> And code isn't consistent either way. So let's change our standard
>>> to something most people like, and eliminate the pain source.
>>>
>>>       
>>
>> Inconsistency is not an argument for or against {}.
>> I don't like single statement blocks without {}
>> because of my personal experience with all kinds
>> of code standard variants.
>>
>> Please don't change the qemu standard, I like it as it is.
>>   
>
> I've never liked this but I would rather not see unnecessary churn so
> I'd prefer to keep the coding style as-is.

The existing code uses both brace styles.  We didn't convert it
wholesale when the "thou shalt use braces" rule was written into the
coding style, because we didn't want the churn.  We can handle it just
the same now.  Churn is not an argument then.

I dislike redundant braces, and support the change Michael proposed.