All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@gmail.com>
To: "Éric Piel" <eric.piel@tremplin-utc.net>
Cc: Samu Onkalo <samu.p.onkalo@nokia.com>,
	linux-kernel@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>,
	"Trisal, Kalhan" <kalhan.trisal@intel.com>,
	Jean Delvare <khali@linux-fr.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [lm-sensors] [RFC][PATCH 0/2] LIS3LV02D I2C driver
Date: Wed, 07 Oct 2009 17:20:39 +0000	[thread overview]
Message-ID: <4ACCCDE7.1090508@gmail.com> (raw)
In-Reply-To: <4ACCC957.3060802@tremplin-utc.net>

Éric Piel wrote:
> Op 07-10-09 18:31, Jonathan Cameron schreef:
>   
>> Just a quick heads up wrt overlapping work.
>>
>> For the i2c support Kalhan Trisal has been posting patches for i2c
>> support for this
>> driver to the lm-sensors list for some time and the latest version of that
>> set is also pretty clean.
>>     
> You mean this post, right?
> http://lists.lm-sensors.org/pipermail/lm-sensors/2009-August/026505.html
> "Accelerometer driver for STMicroeletronics-LIS331DL-three-axis-digital"
> Thanks for the heads up, I had never heard of this driver before.
>   
I think that was the original post. (sorry should have added references!)

> Well, it's for the LIS331DL, not the LIS3LV02DL (12 bits) or the
> LIS302DL (8 bits) (both supported by lis3lv02d driver). That said,
> according to the specs, it seems to be _very_ similar to the LIS302DL,
> they even report the same "who_am_i" value. Just some special features
> are different (free fall detection for instance).
>   
Yes, that's why he was advised to combine it with your driver leading
via about 3 revisions
to
http://lists.lm-sensors.org/pipermail/lm-sensors/2009-October/026840.html
(removed a few pointless headers from previous version
http://lists.lm-sensors.org/pipermail/lm-sensors/2009-September/026706.html
.)


which at first glance is pretty much the same as Samu's driver.
(hence real issue with overlapping work).

I do wonder if it is worth adding a mailing list entry to the driver
MAINTAINERS
entry (unless lm-sensors is where you do want anything relevant to be
discussed?).
Problem here is this evolved in a thread not initially related to your
driver and hence I guess no one noticed you weren't cc'd when it became
relevant.

Jonathan

p.s. Kalhan, btw, just noticed a typo in the patch message :
Macroelectronics->Microelectronics.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@gmail.com>
To: "Éric Piel" <eric.piel@tremplin-utc.net>
Cc: Samu Onkalo <samu.p.onkalo@nokia.com>,
	linux-kernel@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>,
	"Trisal, Kalhan" <kalhan.trisal@intel.com>,
	Jean Delvare <khali@linux-fr.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH 0/2] LIS3LV02D I2C driver
Date: Wed, 07 Oct 2009 18:20:39 +0100	[thread overview]
Message-ID: <4ACCCDE7.1090508@gmail.com> (raw)
In-Reply-To: <4ACCC957.3060802@tremplin-utc.net>

Éric Piel wrote:
> Op 07-10-09 18:31, Jonathan Cameron schreef:
>   
>> Just a quick heads up wrt overlapping work.
>>
>> For the i2c support Kalhan Trisal has been posting patches for i2c
>> support for this
>> driver to the lm-sensors list for some time and the latest version of that
>> set is also pretty clean.
>>     
> You mean this post, right?
> http://lists.lm-sensors.org/pipermail/lm-sensors/2009-August/026505.html
> "Accelerometer driver for STMicroeletronics-LIS331DL-three-axis-digital"
> Thanks for the heads up, I had never heard of this driver before.
>   
I think that was the original post. (sorry should have added references!)

> Well, it's for the LIS331DL, not the LIS3LV02DL (12 bits) or the
> LIS302DL (8 bits) (both supported by lis3lv02d driver). That said,
> according to the specs, it seems to be _very_ similar to the LIS302DL,
> they even report the same "who_am_i" value. Just some special features
> are different (free fall detection for instance).
>   
Yes, that's why he was advised to combine it with your driver leading
via about 3 revisions
to
http://lists.lm-sensors.org/pipermail/lm-sensors/2009-October/026840.html
(removed a few pointless headers from previous version
http://lists.lm-sensors.org/pipermail/lm-sensors/2009-September/026706.html
.)


which at first glance is pretty much the same as Samu's driver.
(hence real issue with overlapping work).

I do wonder if it is worth adding a mailing list entry to the driver
MAINTAINERS
entry (unless lm-sensors is where you do want anything relevant to be
discussed?).
Problem here is this evolved in a thread not initially related to your
driver and hence I guess no one noticed you weren't cc'd when it became
relevant.

Jonathan

p.s. Kalhan, btw, just noticed a typo in the patch message :
Macroelectronics->Microelectronics.

  reply	other threads:[~2009-10-07 17:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01 10:06 [RFC][PATCH 0/2] LIS3LV02D I2C driver Samu Onkalo
2009-10-01 10:06 ` [PATCH 1/2] LIS3LV02D: axis remap, irq and resource setup / release added to platform data Samu Onkalo
2009-10-01 10:06   ` [PATCH 2/2] LIS3LV02D: I2C support Samu Onkalo
2009-10-02  8:20     ` Éric Piel
2009-10-07 16:31 ` [lm-sensors] [RFC][PATCH 0/2] LIS3LV02D I2C driver Jonathan Cameron
2009-10-07 16:31   ` Jonathan Cameron
2009-10-07 17:01   ` [lm-sensors] " Éric Piel
2009-10-07 17:01     ` Éric Piel
2009-10-07 17:20     ` Jonathan Cameron [this message]
2009-10-07 17:20       ` Jonathan Cameron
2009-10-07 17:26     ` [lm-sensors] " Éric Piel
2009-10-07 17:26       ` Éric Piel
2009-10-13 10:13       ` [lm-sensors] " Onkalo Samu
2009-10-13 10:13         ` Onkalo Samu
2009-10-13 10:20         ` Trisal, Kalhan
2009-10-13 10:32           ` [lm-sensors] " Trisal, Kalhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACCCDE7.1090508@gmail.com \
    --to=jonathan.cameron@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=eric.piel@tremplin-utc.net \
    --cc=kalhan.trisal@intel.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=samu.p.onkalo@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.