From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 3/3] Fix compilation issues with CONFIG_DRM_TTM enabled.
Date: Thu, 08 Oct 2009 11:41:39 -0700 [thread overview]
Message-ID: <4ACE3263.7000609@goop.org> (raw)
In-Reply-To: <1255022590-9578-4-git-send-email-konrad.wilk@oracle.com>
On 10/08/09 10:23, Konrad Rzeszutek Wilk wrote:
> The recent fix for GART on Xen included an extra include which
> caused the build to choke when building the ttm drivers.
>
How does the compile fail? (Generally its best to include the
compilation error messages when submitting a compile-fix patch.)
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> arch/x86/include/asm/agp.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/agp.h b/arch/x86/include/asm/agp.h
> index 8107b71..3282ea6 100644
> --- a/arch/x86/include/asm/agp.h
> +++ b/arch/x86/include/asm/agp.h
> @@ -3,7 +3,6 @@
>
> #include <asm/pgtable.h>
> #include <asm/cacheflush.h>
> -#include <asm/dma-mapping.h>
>
The code below uses dma_alloc/free_coherent, so it needs some header for
the prototypes. Perhaps it should be linux/dma-mapping.h?
J
next prev parent reply other threads:[~2009-10-08 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 17:23 [PATCH PV_OPS] Misc fixes Konrad Rzeszutek Wilk
2009-10-08 17:23 ` [PATCH 1/3] Fix toogle whether xenbus driver should be built as module or part of kernel Konrad Rzeszutek Wilk
2009-10-08 17:23 ` [PATCH 2/3] Fix compile warnings: ignoring return value of 'xenbus_register_backend' Konrad Rzeszutek Wilk
2009-10-08 17:23 ` [PATCH 3/3] Fix compilation issues with CONFIG_DRM_TTM enabled Konrad Rzeszutek Wilk
2009-10-08 18:41 ` Jeremy Fitzhardinge [this message]
2009-10-08 19:00 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACE3263.7000609@goop.org \
--to=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.