From: Jonathan Cameron <Jonathan.Cameron-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Rodolfo Giometti
<giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org>,
"Michele De Candia (VT)"
<michele.decandia-EZxuzQJkuwwybS5Ee8rs3A@public.gmane.org>,
Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ALS: TSL2550 driver move from i2c/chips
Date: Fri, 09 Oct 2009 15:53:39 +0100 [thread overview]
Message-ID: <4ACF4E73.5010606@gmail.com> (raw)
In-Reply-To: <4ACF4AC6.7070802-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
Friday afternoon moment....
That id element will need to be signed for any errors on idr allocation
to be detected. Will fix for next version.
> struct tsl2550_data {
> + struct device *classdev;
> struct i2c_client *client;
> struct mutex update_lock;
> + unsigned int id;
>
> unsigned int power_state : 1;
> unsigned int operating_mode : 1;
>
....
>
> + data->id = tsl2550_get_id();
> + if (data->id < 0) {
> + err = data->id;
> + goto exit_kfree;
> + }
>
Jonathan
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@gmail.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: LKML <linux-kernel@vger.kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Jean Delvare <khali@linux-fr.org>,
Rodolfo Giometti <giometti@enneenne.com>,
"Michele De Candia (VT)" <michele.decandia@valueteam.com>,
Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] ALS: TSL2550 driver move from i2c/chips
Date: Fri, 09 Oct 2009 15:53:39 +0100 [thread overview]
Message-ID: <4ACF4E73.5010606@gmail.com> (raw)
In-Reply-To: <4ACF4AC6.7070802@cam.ac.uk>
Friday afternoon moment....
That id element will need to be signed for any errors on idr allocation
to be detected. Will fix for next version.
> struct tsl2550_data {
> + struct device *classdev;
> struct i2c_client *client;
> struct mutex update_lock;
> + unsigned int id;
>
> unsigned int power_state : 1;
> unsigned int operating_mode : 1;
>
....
>
> + data->id = tsl2550_get_id();
> + if (data->id < 0) {
> + err = data->id;
> + goto exit_kfree;
> + }
>
Jonathan
next prev parent reply other threads:[~2009-10-09 14:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 14:37 [PATCH] ALS: TSL2550 driver move from i2c/chips Jonathan Cameron
2009-10-09 14:37 ` Jonathan Cameron
[not found] ` <4ACF4AC6.7070802-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2009-10-09 14:53 ` Jonathan Cameron [this message]
2009-10-09 14:53 ` Jonathan Cameron
2009-10-10 16:33 ` Jean Delvare
2009-10-10 16:33 ` Jean Delvare
[not found] ` <20091010183347.52b043ed-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-10-12 15:13 ` Jonathan Cameron
2009-10-12 15:13 ` Jonathan Cameron
[not found] ` <4AD3477D.4020904-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2009-10-12 15:38 ` Jean Delvare
2009-10-12 15:38 ` Jean Delvare
[not found] ` <20091012173824.0f3ef021-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-11-26 14:17 ` Jean Delvare
2009-11-26 14:17 ` Jean Delvare
2009-10-10 16:52 ` Jean Delvare
2009-10-10 16:52 ` Jean Delvare
2009-10-12 14:19 ` Jonathan Cameron
2009-10-12 15:52 ` Jean Delvare
[not found] ` <20091012175216.6d844623-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-10-12 17:02 ` Jonathan Cameron
2009-10-12 17:02 ` Jonathan Cameron
2009-10-12 18:45 ` Jean Delvare
2009-10-16 1:37 ` Zhang Rui
2009-10-16 1:42 ` Zhang Rui
2009-10-16 1:42 ` Zhang Rui
2009-10-09 15:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACF4E73.5010606@gmail.com \
--to=jonathan.cameron-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org \
--cc=jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michele.decandia-EZxuzQJkuwwybS5Ee8rs3A@public.gmane.org \
--cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.