From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alex Riesen <raa.lkml@gmail.com>,
mstormo@gmail.com, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] Fix the exit code of MSVC build scripts on cygwin
Date: Fri, 09 Oct 2009 23:04:43 +0100 [thread overview]
Message-ID: <4ACFB37B.8010602@ramsay1.demon.co.uk> (raw)
In-Reply-To: <7vy6nl5ag0.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Alex Riesen <raa.lkml@gmail.com> writes:
>>> -exit system(@args);
>>> +system(@args) == 0
>>> + or exit 1;
>>> +exit 0;
>> exit(system(@args) != 0);
>>
>> Yours looks a little verbose...
>
> Thanks, will queue with a fixup.
>
Thanks! (Alex and Junio)
I had this as my penultimate version, so I'm happy.
[I changed it to be more explicit about the actual exit values
returned by the script. (and thus more verbose :) ]
ATB,
Ramsay Jones
prev parent reply other threads:[~2009-10-10 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 15:33 [PATCH] Fix the exit code of MSVC build scripts on cygwin Ramsay Jones
2009-10-08 20:13 ` Alex Riesen
2009-10-09 6:49 ` Junio C Hamano
2009-10-09 22:04 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACFB37B.8010602@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mstormo@gmail.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.