All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
	Junio C Hamano <gitster@pobox.com>,
	mstormo@gmail.com, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] Fix the exit code of MSVC build scripts on cygwin
Date: Thu, 08 Oct 2009 23:49:03 -0700	[thread overview]
Message-ID: <7vy6nl5ag0.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <81b0412b0910081313x31f72916p6fddd1a23df154df@mail.gmail.com> (Alex Riesen's message of "Thu\, 8 Oct 2009 22\:13\:18 +0200")

Alex Riesen <raa.lkml@gmail.com> writes:

> On Thu, Oct 8, 2009 at 17:33, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:
>> diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl
>> index 0ffd59f..26aec61 100644
>> --- a/compat/vcbuild/scripts/clink.pl
>> +++ b/compat/vcbuild/scripts/clink.pl
>> @@ -45,4 +45,6 @@ if ($is_linking) {
>>        push(@args, @cflags);
>>  }
>>  #printf("**** @args\n");
>> -exit system(@args);
>> +system(@args) == 0
>> +       or exit 1;
>> +exit 0;
>
> exit(system(@args) != 0);
>
> Yours looks a little verbose...

Thanks, will queue with a fixup.

  reply	other threads:[~2009-10-09  6:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 15:33 [PATCH] Fix the exit code of MSVC build scripts on cygwin Ramsay Jones
2009-10-08 20:13 ` Alex Riesen
2009-10-09  6:49   ` Junio C Hamano [this message]
2009-10-09 22:04     ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy6nl5ag0.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mstormo@gmail.com \
    --cc=raa.lkml@gmail.com \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.