From: Mick Jordan <Mick.Jordan@Sun.COM>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 4 of 7] minios: fix minios console
Date: Mon, 12 Oct 2009 15:54:44 -0700 [thread overview]
Message-ID: <4AD3B3B4.8050806@Sun.COM> (raw)
In-Reply-To: <alpine.DEB.2.00.0910121759540.4616@kaball-desktop>
On 10/12/09 10:20 AM, Stefano Stabellini wrote:
> MiniOS' console_print tries to expand '\n' into "\n\r" in place, causing
> page faults if the string resides in text.
> Use a duplicate of the string instead.
>
Are you sure this is even necessary? I removed this in my GUK extension
of MiniOS with no apparent effect. The actual push to remove it was
observing that when "piping" the output of one GUK (JVM) guest to
another, the "\n\r" was being treated as two line feeds by the Java
runtime. Why? Because it is "\r\n" that is historically reduced to "\n",
and not "\n\r". In any event in the Xen/Unix environment there should be
no need for the expansion at all. And it really helped to clean up the
console code.
Mick
next prev parent reply other threads:[~2009-10-12 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 17:20 [PATCH 4 of 7] minios: fix minios console Stefano Stabellini
2009-10-12 22:54 ` Mick Jordan [this message]
2009-10-13 12:22 ` Stefano Stabellini
2009-10-13 16:34 ` Mick Jordan
2009-10-13 17:15 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD3B3B4.8050806@Sun.COM \
--to=mick.jordan@sun.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.