From: Lars-Peter Clausen <lars@metafoo.de>
To: Ben Dooks <ben@simtec.co.uk>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
Simtec Linux Team <linux@simtec.co.uk>
Subject: Re: gta02: fix includes
Date: Tue, 13 Oct 2009 01:22:15 +0200 [thread overview]
Message-ID: <4AD3BA27.5000905@metafoo.de> (raw)
In-Reply-To: <20091012201700.042515646@fluff.org.uk>
>Ben Dooks wrote:
>The gta02 build is missing <mach/regs-gpio.h> and is also using the
>incorrect <asm/io.h> header (it should be <linux/io.h>). Fix these
>two problems.
>
>Signed-off-by: Ben Dooks <ben@simtec.co.uk>
>Signed-off-by: Simtec Linux Team <linux@simtec.co.uk>
>
>---
> sound/soc/s3c24xx/neo1973_gta02_wm8753.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>Index: b/sound/soc/s3c24xx/neo1973_gta02_wm8753.c
>===================================================================
>--- a/sound/soc/s3c24xx/neo1973_gta02_wm8753.c 2009-10-10
22:55:53.000000000 +0100
>+++ b/sound/soc/s3c24xx/neo1973_gta02_wm8753.c 2009-10-10
22:58:31.000000000 +0100
>@@ -19,6 +19,8 @@
> #include <linux/interrupt.h>
> #include <linux/platform_device.h>
> #include <linux/gpio.h>
>+#include <linux/io.h>
>+
> #include <sound/core.h>
> #include <sound/pcm.h>
> #include <sound/soc.h>
>@@ -29,7 +31,7 @@
> #include <plat/regs-iis.h>
> #include <mach/regs-clock.h>
>-#include <asm/io.h>
>+#include <mach/regs-gpioj.h>
This file is not using any of the symbols from regs-gpioh.h directly.
It only uses GTA02_GPIO_{HP_IN,AMP_SHUT} from gta02.h which are
defined as S3C2440_GPJX.
So the include of regs-gpioj.h should rather go into gta02.h than here.
- Lars
prev parent reply other threads:[~2009-10-12 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 20:17 gta02: fix includes Ben Dooks
2009-10-12 23:22 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD3BA27.5000905@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=ben@simtec.co.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.