All of lore.kernel.org
 help / color / mirror / Atom feed
* gta02: fix includes
@ 2009-10-12 20:17 Ben Dooks
  2009-10-12 23:22 ` Lars-Peter Clausen
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2009-10-12 20:17 UTC (permalink / raw)
  To: broonie, alsa-devel; +Cc: Simtec Linux Team

[-- Attachment #1: fix-gta02-audio.patch --]
[-- Type: text/plain, Size: 1139 bytes --]

The gta02 build is missing <mach/regs-gpio.h> and is also using the
incorrect <asm/io.h> header (it should be <linux/io.h>). Fix these
two problems.

Signed-off-by: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: Simtec Linux Team <linux@simtec.co.uk>

---
 sound/soc/s3c24xx/neo1973_gta02_wm8753.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: b/sound/soc/s3c24xx/neo1973_gta02_wm8753.c
===================================================================
--- a/sound/soc/s3c24xx/neo1973_gta02_wm8753.c	2009-10-10 22:55:53.000000000 +0100
+++ b/sound/soc/s3c24xx/neo1973_gta02_wm8753.c	2009-10-10 22:58:31.000000000 +0100
@@ -19,6 +19,8 @@
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <linux/gpio.h>
+#include <linux/io.h>
+
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/soc.h>
@@ -29,7 +31,7 @@
 #include <plat/regs-iis.h>
 
 #include <mach/regs-clock.h>
-#include <asm/io.h>
+#include <mach/regs-gpioj.h>
 #include <mach/gta02.h>
 #include "../codecs/wm8753.h"
 #include "s3c24xx-pcm.h"

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: gta02: fix includes
  2009-10-12 20:17 gta02: fix includes Ben Dooks
@ 2009-10-12 23:22 ` Lars-Peter Clausen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2009-10-12 23:22 UTC (permalink / raw)
  To: Ben Dooks; +Cc: alsa-devel, broonie, Simtec Linux Team

>Ben Dooks wrote:
>The gta02 build is missing <mach/regs-gpio.h> and is also using the
>incorrect <asm/io.h> header (it should be <linux/io.h>). Fix these
>two problems.
>
>Signed-off-by: Ben Dooks <ben@simtec.co.uk>
>Signed-off-by: Simtec Linux Team <linux@simtec.co.uk>
>
>---
> sound/soc/s3c24xx/neo1973_gta02_wm8753.c |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

>Index: b/sound/soc/s3c24xx/neo1973_gta02_wm8753.c
>===================================================================
>--- a/sound/soc/s3c24xx/neo1973_gta02_wm8753.c    2009-10-10
22:55:53.000000000 +0100
>+++ b/sound/soc/s3c24xx/neo1973_gta02_wm8753.c    2009-10-10
22:58:31.000000000 +0100
>@@ -19,6 +19,8 @@
> #include <linux/interrupt.h>
> #include <linux/platform_device.h>
> #include <linux/gpio.h>
>+#include <linux/io.h>
>+
> #include <sound/core.h>
> #include <sound/pcm.h>
> #include <sound/soc.h>
>@@ -29,7 +31,7 @@
> #include <plat/regs-iis.h>
 
> #include <mach/regs-clock.h>
>-#include <asm/io.h>
>+#include <mach/regs-gpioj.h>

This file is not using any of the symbols from regs-gpioh.h directly.
It only uses GTA02_GPIO_{HP_IN,AMP_SHUT} from gta02.h which are
defined as S3C2440_GPJX.
So the include of regs-gpioj.h should rather go into gta02.h than here.

- Lars

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-12 23:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-12 20:17 gta02: fix includes Ben Dooks
2009-10-12 23:22 ` Lars-Peter Clausen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.