From: Jason Wessel <jason.wessel@windriver.com>
To: Bernhard Walle <bernhard@bwalle.de>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Andi Kleen <andi@firstfloor.org>,
akpm@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Always print panic message on current console
Date: Tue, 13 Oct 2009 19:02:33 -0500 [thread overview]
Message-ID: <4AD51519.8030902@windriver.com> (raw)
In-Reply-To: <4AD376B9.7040404@bwalle.de>
Bernhard Walle wrote:
> Jesse Barnes schrieb:
>
>> It's called in the panic notifier atm. Yeah sounds like kexec vs
>> notifiers should be reordered a bit (or the current panic notifier
>> should be split into notify and "yes we actually failed to do anything"
>> cases).
>>
>
> Well, we had that discussion several times. But maybe the opinion of
> some developers changed because now there would be an in-kernel user of
> notification before kexec.
>
The other internal kernel user would be kdb (granted it is not merged to
the mainline at this point). The prototype that we demonstrated at LPC
hooked the panic notification first and passed the string that was
passed to the panic.
Where KMS is integrated with KDB all the switching is dynamic and you do
get a chance to see what happened as well as interact with the
debugger. The argument of folks who only care about kexec has always
been they want the first right of anything to get to kexec before
anything could get worse by going down any other code paths.
The kms does not have the choice to dynamically configure the behavior
on panic, where as kdb/kgdb is something you activate if you plan on
debugging (meaning user preference is clear). Perhaps two notifiers is
the right answer.
Jason.
next prev parent reply other threads:[~2009-10-14 0:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 20:51 Always print panic message on current console Bernhard Walle
2009-10-10 20:51 ` [PATCH 1/5] Only define/declare kmsg_redirect when CONFIG_VT_CONSOLE is set Bernhard Walle
2009-10-10 22:56 ` Alan Cox
2009-10-10 20:51 ` [PATCH 2/5] Add setter/getter interface for kmsg_redirect Bernhard Walle
2009-10-10 22:58 ` Alan Cox
2009-10-10 20:51 ` [PATCH 3/5] Use vt_get_kmsg_redirect() and vt_set_kmsg_redirect() Bernhard Walle
2009-10-10 23:06 ` Alan Cox
2009-10-10 23:25 ` Alan Cox
2009-10-10 20:51 ` [PATCH 4/5] Make kmsg_redirect static Bernhard Walle
2009-10-10 20:51 ` [PATCH 5/5] Always print panic message on current console Bernhard Walle
2009-10-12 17:36 ` Andi Kleen
2009-10-12 18:24 ` Bernhard Walle
2009-10-12 18:30 ` Jesse Barnes
2009-10-12 18:34 ` Bernhard Walle
2009-10-14 0:02 ` Jason Wessel [this message]
2009-10-12 18:42 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD51519.8030902@windriver.com \
--to=jason.wessel@windriver.com \
--cc=akpm@linuxfoundation.org \
--cc=andi@firstfloor.org \
--cc=bernhard@bwalle.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.